Re: [PATCH 17/18] lpfc 8.3.42: Fixed issue of task management commands having a fixed timeout

[James Smart <james.smart@emulex.com>]

Jeremy,

Different issues....

The patch addresses only 1 topic - making an attribute to change the 
timeout for the TMF.  This was a request by the distros to post a hack 
that was used on older releases to work around all the serialization and 
delay problems in the midlayer error recovery path - which allowed 
shortening delays from 10-12 minutes to 1-2 minutes. These are the same 
issues we discussed at the last storage forum and which Hannes has been 
working to correct upstream.  The desire is to continue with a like 
tuning option in the driver for those customers that have used it in the 
past.

The other issue - we seem to have missed your prior post. I'll look into 
it shortly.

The two patches work on the same code, but are independent topics.

-- james


On 9/6/2013 2:38 PM, Jeremy Linton wrote:
> On 9/6/2013 11:22 AM, James Smart wrote:
>> Fixed issue of task management commands having a fixed timeout
> 	I'm surprised about this change, since it appears a number of issues in the
> send_taskmgmt() still exist that keep it from handling task management
> failures correctly. It also continues to have a number of smaller issues like
> for example dead code of the form
>
> if (status != IOCB_STATUS)
> else if (status == IOCB_BUSY)
> else
>
>
> 	See patch:
>
> "lpfc should check return status for task mgmt IOCB"
>
> http://marc.info/?l=linux-scsi&m=136242124409687
>
>
>
>