From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/5] iio: refactor info mask and ext_info attribute creation.
Date: Sun, 08 Sep 2013 15:24:51 +0100 [thread overview]
Message-ID: <522C88B3.7070300@kernel.org> (raw)
In-Reply-To: <5228DA76.8080101@metafoo.de>
On 09/05/13 20:24, Lars-Peter Clausen wrote:
> [...]
>> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
>> index cdb034d..ad59fee 100644
>> --- a/include/linux/iio/iio.h
>> +++ b/include/linux/iio/iio.h
>> @@ -38,6 +38,9 @@ enum iio_chan_info_enum {
>> IIO_CHAN_INFO_HYSTERESIS,
>> };
>>
>> +enum iio_shared_by { IIO_SEPARATE,
>> + IIO_SHARED_BY_TYPE };
>> +
>
> That's not kernel style formating, is it?
>
> enum iio_shared_by {
> IIO_SEPARATE,
> IIO_SHARED_BY_TYPE,
> };
>
> ... looks much better in my opinion
>
Fair point, v3 coming up.
> [...]
>
next prev parent reply other threads:[~2013-09-08 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 15:50 [PATCH V2 0/5] IIO: Refactor info_mask* and ext_info handling and introduce info_mask_shared_[by_all/by_type] Jonathan Cameron
2013-08-18 15:50 ` [PATCH 1/5] iio: drop info_mask from struct iio_dev Jonathan Cameron
2013-08-18 15:50 ` [PATCH 2/5] iio: refactor info mask and ext_info attribute creation Jonathan Cameron
2013-09-05 19:24 ` Lars-Peter Clausen
2013-09-08 14:24 ` Jonathan Cameron [this message]
2013-08-18 15:50 ` [PATCH 3/5] iio: add info_mask_[shared_by_dir/shared_by_all] Jonathan Cameron
2013-08-18 15:50 ` [PATCH 4/5] staging:iio: dummy driver additions to show shared_by_dir infomask usage Jonathan Cameron
2013-08-18 15:50 ` [PATCH 5/5] iio:temperature:tmp006 put sampling_frequency in info_mask_shared_by_all Jonathan Cameron
2013-09-01 21:35 ` [PATCH V2 0/5] IIO: Refactor info_mask* and ext_info handling and introduce info_mask_shared_[by_all/by_type] Jonathan Cameron
2013-09-05 19:26 ` Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2013-09-08 13:57 [PATCH V3 " Jonathan Cameron
2013-09-08 13:57 ` [PATCH 2/5] iio: refactor info mask and ext_info attribute creation Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522C88B3.7070300@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.