All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [xen-devel] [Patch 0/4] Xen stack trace printing improvements
Date: Mon, 9 Sep 2013 13:28:27 +0100	[thread overview]
Message-ID: <522DBEEB.90304@citrix.com> (raw)
In-Reply-To: <CE52FA87.5D122%keir.xen@gmail.com>

On 09/09/13 12:09, Keir Fraser wrote:
> On 09/08/2013 20:55, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
>
>> This series consists of improvements to Xen's ability to print traces of its
>> own stack, and specifically for the stack overflow case to be able to use
>> frame pointers in a debug build.
>>
>> I have dev tested the series in debug and non-debug cases, with and without
>> memory guards, and I believe that all the stack traces look correct.  However,
>> I would greatly appreciate a second opinion on the boundary conditions.
>>
>> The 4th patch is included for anyone wishing to easily test the series; It is
>> not intended for committing.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Keir Fraser <keir@xen.org>
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Tim Deegan <tim@xen.org>
> Acked-by: Keir Fraser <keir@xen.org>
>
>

Thanks for the ack, but I would like to hold off on committing this
until I have fixed the bug for following frame pointers through
exception frames.

~Andrew

  reply	other threads:[~2013-09-09 12:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 19:55 [xen-devel] [Patch 0/4] Xen stack trace printing improvements Andrew Cooper
2013-08-09 19:55 ` [xen-devel] [Patch 1/4] x86/stack: Refactor show_trace() Andrew Cooper
2013-08-09 19:55 ` [xen-devel] [Patch 2/4] x86/stack: Adjust boundary conditions for printed stacks Andrew Cooper
2013-08-12  8:46   ` Jan Beulich
2013-08-12  9:43     ` Andrew Cooper
2013-08-12  9:49       ` Jan Beulich
2013-08-12 12:15         ` [xen-devel] [Patch v2 " Andrew Cooper
2013-08-12 13:44           ` Jan Beulich
2013-08-12 13:53             ` Andrew Cooper
2013-08-09 19:55 ` [xen-devel] [Patch 3/4] x86/stack: Change show_stack_overflow() to use frame pointers if available Andrew Cooper
2013-08-09 19:55 ` [xen-devel] [Patch 4/4] DO NOT APPLY: Test code for interesting stack overflows Andrew Cooper
2013-09-09 11:09 ` [xen-devel] [Patch 0/4] Xen stack trace printing improvements Keir Fraser
2013-09-09 12:28   ` Andrew Cooper [this message]
2013-09-09 12:44     ` Jan Beulich
2013-09-09 12:50       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522DBEEB.90304@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.