From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [xen-devel] [Patch 0/4] Xen stack trace printing improvements Date: Mon, 9 Sep 2013 13:50:47 +0100 Message-ID: <522DC427.1020206@citrix.com> References: <522DBEEB.90304@citrix.com> <522DDEDC02000078000F17CF@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <522DDEDC02000078000F17CF@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Tim Deegan , Xen-devel List-Id: xen-devel@lists.xenproject.org On 09/09/13 13:44, Jan Beulich wrote: >>>> On 09.09.13 at 14:28, Andrew Cooper wrote: >> On 09/09/13 12:09, Keir Fraser wrote: >>> On 09/08/2013 20:55, "Andrew Cooper" wrote: >>> >>>> This series consists of improvements to Xen's ability to print traces of its >>>> own stack, and specifically for the stack overflow case to be able to use >>>> frame pointers in a debug build. >>>> >>>> I have dev tested the series in debug and non-debug cases, with and without >>>> memory guards, and I believe that all the stack traces look correct. >> However, >>>> I would greatly appreciate a second opinion on the boundary conditions. >>>> >>>> The 4th patch is included for anyone wishing to easily test the series; It >> is >>>> not intended for committing. >>>> >>>> Signed-off-by: Andrew Cooper >>>> CC: Keir Fraser >>>> CC: Jan Beulich >>>> CC: Tim Deegan >>> Acked-by: Keir Fraser >>> >>> >> Thanks for the ack, but I would like to hold off on committing this >> until I have fixed the bug for following frame pointers through >> exception frames. > Ah, that's why you didn't ping for an ack yourself? I had this in my > to-be-committed-eventually list of things, but with your comment > above I assume you'll re-submit once you sorted out that remaining > item, and I can therefore drop it from that list of mine. > > Jan > Yes - it is high up my todo list, but there are some regressions moving to 4.3 which are higher up. ~Andrew