From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH/RFC v3 00/19] Common Display Framework Date: Mon, 9 Sep 2013 17:58:06 +0300 Message-ID: <522DE1FE.9030508@ti.com> References: <1376068510-30363-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1599910.F5touEILFq@avalon> <20130821070947.GM31036@pengutronix.de> <522DBB38.2040109@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1809846677==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTP id CD3E1E5C48 for ; Mon, 9 Sep 2013 07:58:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Linux Fbdev development list , "dri-devel@lists.freedesktop.org" , Jesse Barnes , Laurent Pinchart , Benjamin Gaignard , Laurent Pinchart , Tom Gall , Ragesh Radhakrishnan , "linux-media@vger.kernel.org" , Stephen Warren , Mark Zhang , Alexandre Courbot , Thomas Petazzoni , Sunil Joshi , Kyungmin Park , Maxime Ripard , Vikas Sajjan , Marcus Lorentzon List-Id: dri-devel@lists.freedesktop.org --===============1809846677== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SqBJbk7gaqhQXaWtN2H2i0r76mwDnbBIc" --SqBJbk7gaqhQXaWtN2H2i0r76mwDnbBIc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/09/13 17:17, Rob Clark wrote: > On Mon, Sep 9, 2013 at 8:12 AM, Tomi Valkeinen = wrote: >> On 21/08/13 15:22, Rob Clark wrote: >> >>> And just to be clear, part of my negative experience about this is th= e >>> omapdss/omapdrm split. I just see cfd outside of drm as encouraging >>> others to make the same mistake. >> >> Feel free to disagree, but I think the omapdss/omapdrm split is a bit >> different matter. The main problem there was splitting the control of = a >> single device (OMAP DSS, and more specifically, DISPC) into two. >=20 > I don't completely care about the *device* split (we have drm drivers > that are multiple devices), as much as the directory and code layout > split. >=20 > We have helper code for edid probing, DP, etc in drm. Drivers should > be using this to avoid duplicating code unnecessarily. But that gets > difficult when the drivers are outside of drm. (That is the best case > scenario, assuming we avoid any impedance mismatch between CDF and > KMS, that we come up with a way to share property code, etc.) Ok, I thought you were referring to the apply etc. stuff we spent lots of time solving for omapdss/omapdrm. That all was caused by the split we have for the control for DISPC. I, on the other hand, don't so much care about duplicating code. Sure, I always try to avoid it. But if I need a helper in non-DRM context that does the same thing as a helper DRM already has, I don't see any issue in implementing it. In fact, I'd prefer at least some of the helpers DRM has (say, videomode related and EDID parsing) to be moved out from DRM. There's no reason to tie them to DRM. That would avoid code duplication. Tomi --SqBJbk7gaqhQXaWtN2H2i0r76mwDnbBIc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSLeH+AAoJEPo9qoy8lh71ZwkP/RRTmLq/E7WwnvlNn8XoVLbJ pXCJqMiy58cRmpg3ltApPum2DI3h5PLYRuxPm40vFqcNuA9XGeVHzboXxUN6IKPH F4tyHdAdKbKcmsPhmAI1aZfljFH2rqf/gLkCM7vYX/Agjygyswv3al7KKhp5QvLy AwwelJvtrJpmNcMDbgv+TSJahq/vftnXv7eQBumpORdod7r8Lc6QdX8pHXLw57We YWVm4D1UWtEHvrnPYQk0Qr8sGjWWAlIN7ho7VGYbduf+TVNcZAH8/BFOXJTEBgtY xt66ZXxkXiQHHg3MAdWg63J+IaZZqHuHUMfsJvSWt+mWMHUnpCikI8HSHo3//yJa 2EynJCWq9nfwhstH4h5sfpjSIAfQMBhIvztIqFA6W2XhdeJdXfMYZl5OlFZyVxQg NFv+BtPSn/NfnTXMfzty/ZVb1muFrXKCWPjVfVw7q4sF2+oC20OYUzY2oJEz6fTJ VRZU3O4AwsQngNHN3nkoDPLrw4kTy9UTaZGt+IW+r0wUH+NaK4g1w4jJJ6+qRsdq JJ/zSsT+CEnWRfkOjZUIOXO/XKHJBdRodbq/hFsXJwUTZ88HPGCQOyZSLIaYbu45 hOT5AsU8IpPhW/Z+IWom3zk7bJeJ+zT3NJIiKrLDK+lm2J545/kdtjrCIqrG7ru+ Jaxw+Ex/PfgMB5D30Z2C =G86r -----END PGP SIGNATURE----- --SqBJbk7gaqhQXaWtN2H2i0r76mwDnbBIc-- --===============1809846677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1809846677==--