From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
Date: Mon, 09 Sep 2013 10:02:23 -0500 [thread overview]
Message-ID: <522DE2FF.2080001@gmail.com> (raw)
In-Reply-To: <20130909140629.4614D380DE2@gemini.denx.de>
On 09/09/2013 09:06 AM, Wolfgang Denk wrote:
> Dear Rob Herring,
>
> In message <1378670088-17602-1-git-send-email-robherring2@gmail.com> you wrote:
>>
> ...
>> diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
>> index e59ee96..4c25289 100644
>> --- a/include/config_fallbacks.h
>> +++ b/include/config_fallbacks.h
>> @@ -53,4 +53,8 @@
>> #define HAVE_BLOCK_DEVICE
>> #endif
>>
>> +#ifndef CONFIG_SYS_HZ
>> +#define CONFIG_SYS_HZ 1000
>> +#endif
>
> This should be not a fallback (i. e. default value) which can be
> silently overwritten - this should be a mandatory definition that
> causes build errors if somebody tries to define a different value.
What do I do with current boards that are wrong? I should make all these
boards have build errors or fix them to use 1000 which may break them at
runtime depending on their possible misuse of CONFIG_SYS_HZ?
include/configs/KAREF.h:#define CONFIG_SYS_HZ 100
/* decr freq: 1 ms ticks */
include/configs/M5271EVB.h:#define CONFIG_SYS_HZ
1000000
include/configs/METROBOX.h:#define CONFIG_SYS_HZ
100 /* decr freq: 1 ms ticks */
include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 10000
include/configs/idmr.h:#define CONFIG_SYS_HZ
(50000000 / 64)
include/configs/mini2440.h:#define CONFIG_SYS_HZ
1562500
include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400
include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ
((V_SCLK) / (2 << CONFIG_SYS_PTV))
include/configs/omap730p2.h:#define CONFIG_SYS_HZ
((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV))
include/configs/rsk7203.h:#define CONFIG_SYS_HZ
(CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
include/configs/rsk7264.h:#define CONFIG_SYS_HZ
(CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
include/configs/rsk7269.h:#define CONFIG_SYS_HZ
(CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400
/* incrementer freq: 3.6864 MHz */
include/configs/versatile.h:#define CONFIG_SYS_HZ
(1000000 / 256)
Rob
next prev parent reply other threads:[~2013-09-09 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 19:54 [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition Rob Herring
2013-09-09 14:06 ` Wolfgang Denk
2013-09-09 15:02 ` Rob Herring [this message]
2013-09-09 15:41 ` Wolfgang Denk
2013-09-19 19:06 ` Tom Rini
2013-09-19 21:02 ` Rob Herring
2013-09-19 22:13 ` Tom Rini
2013-09-21 20:03 ` [U-Boot] [PATCH v2] " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 0/3] Consolidate " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 1/3] config: consolidate " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 2/3] config: remove platform CONFIG_SYS_HZ definition part 1/2 Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 3/3] config: remove platform CONFIG_SYS_HZ definition part 2/2 Rob Herring
2013-11-04 21:31 ` [U-Boot] [PATCH v3 0/3] Consolidate CONFIG_SYS_HZ definition Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DE2FF.2080001@gmail.com \
--to=robherring2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.