diff for duplicates of <522DE822.3030907@arm.com> diff --git a/a/1.txt b/N1/1.txt index 00eb164..77405e2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,16 @@ On 09/09/13 15:32, Shawn Guo wrote: > Hi Sudeep, -> +>=20 > On Mon, Sep 09, 2013 at 10:24:39AM +0100, Sudeep KarkadaNagesha wrote: >> Hi Shawn, >> >> Can you please clarify ? The fix would be as below but I would like to >> know if setting cpu_dev to get_cpu_device(0) instead of &pdev->dev has >> any impact on other parts of code using cpu_dev ? -> +>=20 > I'm sorry. I should have given it a test on hardware before ACKing the > changes. -> +>=20 > The fix below should not have other impact except the prefix of dev_err > [info, dbg] message output ('cpufreq-cpu0:' to 'cpu cpu0:'), which > shouldn't be a problem. @@ -35,7 +35,8 @@ I don't have a strong opinion though. Let me know how would you like to fix this. >> ->> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c +>> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cp= +u0.c >> index cbfffa9..871c336 100644 >> --- a/drivers/cpufreq/cpufreq-cpu0.c >> +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -44,16 +45,16 @@ Let me know how would you like to fix this. >> struct device_node *np; >> int ret; >> ->> - cpu_dev = &pdev->dev; ->> + cpu_dev = get_cpu_device(0); +>> - cpu_dev =3D &pdev->dev; +>> + cpu_dev =3D get_cpu_device(0); >> ->> np = of_node_get(cpu_dev->of_node); +>> np =3D of_node_get(cpu_dev->of_node); >> if (!np) { >> -> +>=20 > The imx6q-cpufreq driver needs a similar fixing. Please include the > following changes into your fixing patches. Thanks. -> +>=20 Ok no problem I can post the fix based on response for the above question. Regard, diff --git a/a/content_digest b/N1/content_digest index 05e31ac..60607c3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,36 +8,35 @@ "Subject\0Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes\0" "Date\0Mon, 09 Sep 2013 16:24:18 +0100\0" "To\0Shawn Guo <shawn.guo@linaro.org>\0" - "Cc\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>" - Guennadi Liakhovetski <g.liakhovetski@gmx.de> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> + "Cc\0Jonas Bonn <jonas@southpole.se>" devicetree@vger.kernel.org <devicetree@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - Viresh Kumar <viresh.kumar@linaro.org> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Benjamin Herrenschmidt <benh@kernel.crashing.org> - Jonas Bonn <jonas@southpole.se> Michal Simek <monstr@monstr.eu> + linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> + Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com> + Viresh Kumar <viresh.kumar@linaro.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + rob.herring@calxeda.com <rob.herring@calxeda.com> Rafael J. Wysocki <rjw@sisk.pl> + Greg Kroah-Hartman <gregkh@linuxfoundation.org> grant.likely@linaro.org <grant.likely@linaro.org> - " rob.herring@calxeda.com <rob.herring@calxeda.com>\0" + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + Guennadi Liakhovetski <g.liakhovetski@gmx.de> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" "On 09/09/13 15:32, Shawn Guo wrote:\n" "> Hi Sudeep,\n" - "> \n" + ">=20\n" "> On Mon, Sep 09, 2013 at 10:24:39AM +0100, Sudeep KarkadaNagesha wrote:\n" ">> Hi Shawn,\n" ">>\n" ">> Can you please clarify ? The fix would be as below but I would like to\n" ">> know if setting cpu_dev to get_cpu_device(0) instead of &pdev->dev has\n" ">> any impact on other parts of code using cpu_dev ?\n" - "> \n" + ">=20\n" "> I'm sorry. I should have given it a test on hardware before ACKing the\n" "> changes.\n" - "> \n" + ">=20\n" "> The fix below should not have other impact except the prefix of dev_err\n" "> [info, dbg] message output ('cpufreq-cpu0:' to 'cpu cpu0:'), which\n" "> shouldn't be a problem.\n" @@ -62,7 +61,8 @@ "Let me know how would you like to fix this.\n" "\n" ">>\n" - ">> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c\n" + ">> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cp=\n" + "u0.c\n" ">> index cbfffa9..871c336 100644\n" ">> --- a/drivers/cpufreq/cpufreq-cpu0.c\n" ">> +++ b/drivers/cpufreq/cpufreq-cpu0.c\n" @@ -71,19 +71,19 @@ ">> struct device_node *np;\n" ">> int ret;\n" ">>\n" - ">> - cpu_dev = &pdev->dev;\n" - ">> + cpu_dev = get_cpu_device(0);\n" + ">> - cpu_dev =3D &pdev->dev;\n" + ">> + cpu_dev =3D get_cpu_device(0);\n" ">>\n" - ">> np = of_node_get(cpu_dev->of_node);\n" + ">> np =3D of_node_get(cpu_dev->of_node);\n" ">> if (!np) {\n" ">>\n" - "> \n" + ">=20\n" "> The imx6q-cpufreq driver needs a similar fixing. Please include the\n" "> following changes into your fixing patches. Thanks.\n" - "> \n" + ">=20\n" "Ok no problem I can post the fix based on response for the above question.\n" "\n" "Regard,\n" Sudeep -cc04ab34bb1d93672e40761866d1af740082bc27d42335cdd163400a351318f4 +0e653c325c0bcd6fbd0b320c20634b8627f5ecfe0f6cd16b234514bc15d6d5c7
diff --git a/a/content_digest b/N2/content_digest index 05e31ac..1fcbe39 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,25 +4,10 @@ "ref\0Pine.LNX.4.64.1309061539310.11068@axis700.grange\0" "ref\0522D93D7.4010307@arm.com\0" "ref\020130909143253.GD4624@S2101-09.ap.freescale.net\0" - "From\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>\0" - "Subject\0Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes\0" + "From\0Sudeep.KarkadaNagesha@arm.com (Sudeep KarkadaNagesha)\0" + "Subject\0[PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes\0" "Date\0Mon, 09 Sep 2013 16:24:18 +0100\0" - "To\0Shawn Guo <shawn.guo@linaro.org>\0" - "Cc\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>" - Guennadi Liakhovetski <g.liakhovetski@gmx.de> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> - devicetree@vger.kernel.org <devicetree@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - Viresh Kumar <viresh.kumar@linaro.org> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Benjamin Herrenschmidt <benh@kernel.crashing.org> - Jonas Bonn <jonas@southpole.se> - Michal Simek <monstr@monstr.eu> - Rafael J. Wysocki <rjw@sisk.pl> - grant.likely@linaro.org <grant.likely@linaro.org> - " rob.herring@calxeda.com <rob.herring@calxeda.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 09/09/13 15:32, Shawn Guo wrote:\n" @@ -86,4 +71,4 @@ "Regard,\n" Sudeep -cc04ab34bb1d93672e40761866d1af740082bc27d42335cdd163400a351318f4 +7cb12a50027ab4b0fe06b375689f9e8f37328ef4e76d3961abf64f91a1b0d31b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.