From: Stefan Weil <sw@weilnetz.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Richard Henderson <rth@twiddle.net>,
qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64
Date: Mon, 09 Sep 2013 18:14:34 +0200 [thread overview]
Message-ID: <522DF3EA.6060606@weilnetz.de> (raw)
In-Reply-To: <20130909145302.GB4966@ohm.aurel32.net>
Am 09.09.2013 16:53, schrieb Aurelien Jarno:
> On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote:
>> Am 04.09.2013 22:49, schrieb Stefan Weil:
>>> It is used by qemu-ppc64 when running Debian's busybox-static.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>>
>>> This patch is also useful for QEMU 1.6.
>> ... so I should have added qemu-stable. Done now.
>>
> Why is it needed for qemu-stable? It should only improve performance, as
> these two ops are not mandatory ops. In general I don't think we should
> have performance improvements in a stable minor release (unless of course
> it's a big regression from previous).
Hi Aurelien,
tci has always set TCG_TARGET_HAS_rot_i64, and target-ppc64 uses the
rotl_i64 and rotr_i64 TCG opcodes.
The old implementation just triggered a TODO assertion. That's how I
implemented TCI: I started with TODO assertions for all opcodes and
replaced them by real code as soon as I got a test case which used them.
Now I have a test case :-)
=> It's not a performance issue, but fixes a fatal assertion.
=> It should be used in 1.6.
Regards,
Stefan
next prev parent reply other threads:[~2013-09-09 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 20:49 [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64 Stefan Weil
2013-09-04 20:51 ` Stefan Weil
2013-09-09 14:53 ` Aurelien Jarno
2013-09-09 16:14 ` Stefan Weil [this message]
2013-09-09 16:47 ` Aurelien Jarno
2013-09-04 23:00 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2013-09-05 12:00 Jay Foad
2013-09-05 20:17 ` Stefan Weil
2013-09-05 20:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DF3EA.6060606@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.