From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Paul Brook <paul@codesourcery.com>,
Antony Pavlov <antonynpavlov@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox
Date: Mon, 09 Sep 2013 16:07:52 -0700 [thread overview]
Message-ID: <522E54C8.9020305@twiddle.net> (raw)
In-Reply-To: <20130909173234.GC4966@ohm.aurel32.net>
On 09/09/2013 10:32 AM, Aurelien Jarno wrote:
>> +#define SZ_2G 0x80000000
At minimum this must have a U or LL suffix.
And if this one has the suffix, then for consistency the rest ought as well.
r~
next prev parent reply other threads:[~2013-09-09 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 7:35 [Qemu-devel] [RFC 0/2] use sizes.h macros for power-of-two sizes Antony Pavlov
2013-09-04 7:35 ` [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox Antony Pavlov
2013-09-09 17:32 ` Aurelien Jarno
2013-09-09 17:35 ` Paolo Bonzini
2013-09-09 19:21 ` Stefan Weil
2013-09-09 23:07 ` Richard Henderson [this message]
2013-09-04 7:35 ` [Qemu-devel] [RFC 2/2] hw/mips: use sizes.h macros Antony Pavlov
2013-09-09 17:33 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522E54C8.9020305@twiddle.net \
--to=rth@twiddle.net \
--cc=anthony@codemonkey.ws \
--cc=antonynpavlov@gmail.com \
--cc=aurelien@aurel32.net \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.