From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V1 21/29] xen/arm: Create a fake GIC node in
 dom0 device tree
Date: Tue, 10 Sep 2013 11:49:45 +0100
Message-ID: <522EF949.7070804@linaro.org>
References: <1377701263-3319-1-git-send-email-julien.grall@linaro.org>
	<1377701263-3319-22-git-send-email-julien.grall@linaro.org>
	<1378727343.19967.78.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1378727343.19967.78.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, andre.przywara@linaro.org, patches@linaro.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 09/09/2013 12:49 PM, Ian Campbell wrote:
> On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote:
>> @@ -514,6 +587,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
>>          DT_MATCH_COMPATIBLE("xen,multiboot-module"),
>>          DT_MATCH_COMPATIBLE("arm,psci"),
>>          DT_MATCH_PATH("/cpus"),
>> +        DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"),
> 
> This will need changing as we change the list in gic.c.
> 
> Is there some way we can make this generic by using
> dt_interrupt_controller->compatible?

compatible is a list of zeroed string. How about a define in gic.h?

#define GIC_COMPATIBLE                   \
  DT_MATCH_PATH("arm,cortex-a15-gic)

So we can use in the different place.

> Otherwise I think we either need a comment at both locations or way to
> share the lists.
> 
> Ian.
> 
>>          { /* sentinel */ },
>>      };
>>      const struct dt_device_node *child;
> 
> 


-- 
Julien Grall