All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 2/2] libxl: fix libxl__device_disk_from_xs_be to parse backend domid
Date: Tue, 10 Sep 2013 14:08:55 +0200	[thread overview]
Message-ID: <522F0BD7.8050402@citrix.com> (raw)
In-Reply-To: <1378808071.21748.76.camel@kazak.uk.xensource.com>

On 10/09/13 12:14, Ian Campbell wrote:
> On Fri, 2013-09-06 at 12:36 +0200, Roger Pau Monne wrote:
>> libxl__device_disk_from_xs_be was ignoring the backend domid, setting
>> it to 0 by default. Fix this by parsing the backend disk path in order
>> to fetch the backend domid.
>>
>> This fixes the issue reported when trying to block-detach disks that
>> have it's backend on a driver domain.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Reported-by: G.R. <firemeteor@users.sourceforge.net>
>> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
> 
> It's a bit lame that there's no better way but this is indeed what
> people (including frontends) do, so:
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> I'm pretty sure this can go in without patch 1/2 being in yet, but
> please confirm.

Indeed, it can go in without 1 being committed.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-09-10 12:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 10:36 [PATCH 0/2] libxl: fixes for driver domains Roger Pau Monne
2013-09-06 10:36 ` [PATCH 1/2] libxl: correctly list disks served by driver domains in block-list Roger Pau Monne
2013-09-10 10:11   ` Ian Campbell
2013-09-10 12:06     ` Roger Pau Monné
2013-09-10 12:54       ` Ian Campbell
2013-09-10 13:55         ` Roger Pau Monné
2013-09-10 14:23           ` Ian Campbell
2013-09-10 14:54             ` [PATCH] libxl: set permissions for xs frontend entry pointing to xs backend Roger Pau Monne
2013-09-10 15:02               ` Ian Campbell
2013-09-10 15:03                 ` Roger Pau Monné
2013-09-10 15:06                   ` Ian Campbell
2013-09-10 15:12               ` Ian Jackson
2013-09-10 15:16                 ` Ian Campbell
2013-09-10 15:19                   ` Ian Jackson
2013-09-10 15:23                     ` Ian Campbell
2013-09-10 15:43                       ` Ian Jackson
2013-09-10 15:19                 ` Roger Pau Monné
2013-09-10 15:24                   ` Ian Campbell
2013-09-06 10:36 ` [PATCH 2/2] libxl: fix libxl__device_disk_from_xs_be to parse backend domid Roger Pau Monne
2013-09-10 10:14   ` Ian Campbell
2013-09-10 12:08     ` Roger Pau Monné [this message]
2013-09-13 12:32       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522F0BD7.8050402@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.