From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/1 V3] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed Date: Tue, 10 Sep 2013 14:02:34 +0100 Message-ID: <522F186A.4020800@citrix.com> References: <1378741940-11192-1-git-send-email-suravee.suthikulpanit@amd.com> <522F30EA02000078000F1E20@nat28.tlf.novell.com> <522F1621.2020007@citrix.com> <522F33DC02000078000F1E50@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VJNaY-0003be-KX for xen-devel@lists.xenproject.org; Tue, 10 Sep 2013 13:02:38 +0000 In-Reply-To: <522F33DC02000078000F1E50@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , xiantao.zhang@intel.com, stefan.bader@canonical.com, suravee.suthikulpanit@amd.com List-Id: xen-devel@lists.xenproject.org On 10/09/13 13:59, Jan Beulich wrote: >>>> On 10.09.13 at 14:52, Andrew Cooper wrote: >> On 10/09/13 13:47, Jan Beulich wrote: >>>>>> On 09.09.13 at 17:52, wrote: >>>> + { >>>> + AMD_IOMMU_DEBUG("Skipping host bridge %04x:%02x:%02x.%u (type %x)\n", >>>> + pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), PCI_FUNC(bdf), >>>> + pdev->type); >>> Saying "host bridge" _and_ being in a conditional only allowing host >>> bridges in makes printing the type redundant. >> I specifically asked for "host bridge" here for the benefit of people >> just reading the boot dmesg. > And I'm not arguing about its usefulness. I'm asking for the printing > of type to be removed. > > Jan > Oops sorry - yes. I mis-infered your meaning. I agree that the (type %x) is superfluous ~Andrew