diff for duplicates of <522F2A50.3070604@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 427f6ed..c3cac08 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On 09/07/2013 02:51 PM, Daniel Borkmann wrote: > so that we do *not* find a single address in the association's bind address > list that is not in the packed array of addresses. If this happens when we > have an established association with ASCONF-capable peers, then we could get -> a NULL pointer dereference as we only check for laddr = NULL && addrcnt = 1 +> a NULL pointer dereference as we only check for laddr == NULL && addrcnt == 1 > and call later sctp_make_asconf_update_ip() with NULL laddr. > > BUT: this actually won't happen as sctp_bindx_rem() will catch such a case @@ -47,7 +47,7 @@ Acked-by: Vlad Yasevich <vyasevich@gmail.com> > goto skip_mkasconf; > } > -> + if (laddr = NULL) +> + if (laddr == NULL) > + return -EINVAL; > + > /* We do not need RCU protection throughout this loop diff --git a/a/content_digest b/N1/content_digest index 50bd584..ff3fe53 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01378579881-27881-1-git-send-email-dborkman@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net] net: sctp: fix smatch warning in sctp_send_asconf_del_ip\0" - "Date\0Tue, 10 Sep 2013 14:18:56 +0000\0" + "Date\0Tue, 10 Sep 2013 10:18:56 -0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -26,7 +26,7 @@ "> so that we do *not* find a single address in the association's bind address\n" "> list that is not in the packed array of addresses. If this happens when we\n" "> have an established association with ASCONF-capable peers, then we could get\n" - "> a NULL pointer dereference as we only check for laddr = NULL && addrcnt = 1\n" + "> a NULL pointer dereference as we only check for laddr == NULL && addrcnt == 1\n" "> and call later sctp_make_asconf_update_ip() with NULL laddr.\n" ">\n" "> BUT: this actually won't happen as sctp_bindx_rem() will catch such a case\n" @@ -59,7 +59,7 @@ "> \t\t\tgoto skip_mkasconf;\n" "> \t\t}\n" ">\n" - "> +\t\tif (laddr = NULL)\n" + "> +\t\tif (laddr == NULL)\n" "> +\t\t\treturn -EINVAL;\n" "> +\n" "> \t\t/* We do not need RCU protection throughout this loop\n" @@ -67,4 +67,4 @@ "> \t\t * setsockopt call.\n" > -4e8c14316b21fb3218098eb73f8cd5ed6e8dccb5d7fa25e680e9112e10caf854 +de1c6495b179fff4ca567d67394d181a0263a9ac9332df1ea9d4fbe716cb0cb7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.