From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'John W. Linville'" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
'Chaoming Li' <chaoming_li@realsil.com.cn>
Subject: Re: [PATCH 02/12] wireless: rtlwifi: remove unnecessary pci_set_drvdata()
Date: Tue, 10 Sep 2013 09:34:19 -0500 [thread overview]
Message-ID: <522F2DEB.1090903@lwfinger.net> (raw)
In-Reply-To: <00b301ceae17$7f417480$7dc45d80$%han@samsung.com>
On 09/10/2013 06:18 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 703f839..2b6d3e0 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -2009,7 +2009,6 @@ fail2:
> fail1:
> if (hw)
> ieee80211_free_hw(hw);
> - pci_set_drvdata(pdev, NULL);
> pci_disable_device(pdev);
>
> return err;
> @@ -2064,8 +2063,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
>
> rtl_pci_disable_aspm(hw);
>
> - pci_set_drvdata(pdev, NULL);
> -
> ieee80211_free_hw(hw);
> }
> EXPORT_SYMBOL(rtl_pci_disconnect);
>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
next prev parent reply other threads:[~2013-09-10 14:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
2013-09-10 11:30 ` Emmanuel Grumbach
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
2013-09-10 14:34 ` Larry Finger [this message]
2013-09-10 11:19 ` [PATCH 03/12] wireless: iwlegacy: " Jingoo Han
2013-09-10 11:22 ` [PATCH 04/12] wireless: adm8211: " Jingoo Han
2013-09-10 11:23 ` [PATCH 05/12] wireless: airo: " Jingoo Han
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
2013-09-10 11:25 ` Jingoo Han
2013-09-10 21:56 ` Kalle Valo
2013-09-10 21:56 ` Kalle Valo
2013-09-11 0:32 ` Jingoo Han
2013-09-11 0:32 ` Jingoo Han
2013-09-12 16:23 ` Kalle Valo
2013-09-12 16:23 ` Kalle Valo
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
2013-09-15 7:46 ` Vladimir Kondratiev
2013-09-10 11:27 ` [PATCH 08/12] wireless: ipw2x00: " Jingoo Han
2013-09-10 11:27 ` [PATCH 09/12] wireless: mwl8k: " Jingoo Han
2013-09-10 11:29 ` [PATCH 10/12] wireless: orinoco: " Jingoo Han
2013-09-10 11:30 ` [PATCH 11/12] wireless: p54pci: " Jingoo Han
2013-09-10 11:32 ` [PATCH 12/12] wireless: rtl818x: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F2DEB.1090903@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=jg1.han@samsung.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.