From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Matthew Daley <mattjd@gmail.com>
Cc: Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 7/8] kdd: fix free of array-typed value
Date: Tue, 10 Sep 2013 15:46:02 +0100 [thread overview]
Message-ID: <522F30AA.6050901@citrix.com> (raw)
In-Reply-To: <1378823662-20803-8-git-send-email-mattjd@gmail.com>
On 10/09/13 15:34, Matthew Daley wrote:
> g->id is an array and is allocated as part of g itself; it's not a
> separate allocation.
>
> Coverity-ID: 1054980
> Signed-off-by: Matthew Daley <mattjd@gmail.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> tools/debugger/kdd/kdd-xen.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/debugger/kdd/kdd-xen.c b/tools/debugger/kdd/kdd-xen.c
> index 4fbea7d..f3f9529 100644
> --- a/tools/debugger/kdd/kdd-xen.c
> +++ b/tools/debugger/kdd/kdd-xen.c
> @@ -619,7 +619,6 @@ void kdd_guest_teardown(kdd_guest *g)
> {
> flush_maps(g);
> xc_interface_close(g->xc_handle);
> - free(g->id);
> free(g->hvm_buf);
> free(g);
> }
next prev parent reply other threads:[~2013-09-10 14:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 14:34 [PATCH 0/8] Fixes for various minor Coverity issues Matthew Daley
2013-09-10 14:34 ` [PATCH 1/8] x86: add missing va_end to hypercall_xlat_continuation Matthew Daley
2013-09-10 14:41 ` Andrew Cooper
2013-09-10 15:02 ` Keir Fraser
2013-09-10 14:34 ` [PATCH 2/8] sched/arinc653: check for guest data transfer failures Matthew Daley
2013-09-10 14:43 ` Andrew Cooper
2013-09-10 14:50 ` George Dunlap
2013-09-10 17:35 ` Kathy Hadley
2013-09-10 19:45 ` Ian Campbell
2013-09-10 15:03 ` Keir Fraser
2013-09-10 14:34 ` [PATCH 3/8] libxl: fix use-after-free in discard_events iteration Matthew Daley
2013-09-10 14:45 ` Ian Jackson
2013-09-10 14:34 ` [PATCH 4/8] libxl: correctly handle readlink() errors Matthew Daley
2013-09-10 14:47 ` Ian Jackson
2013-09-10 14:34 ` [PATCH 5/8] mini-os: fix use-after-free in xs_daemon_close event iteration Matthew Daley
2013-09-10 14:37 ` Samuel Thibault
2013-09-10 14:34 ` [PATCH 6/8] mini-os: handle possibly overlong _nodename in init_consfront Matthew Daley
2013-09-10 14:38 ` Samuel Thibault
2013-09-10 14:34 ` [PATCH 7/8] kdd: fix free of array-typed value Matthew Daley
2013-09-10 14:41 ` Tim Deegan
2013-09-10 14:46 ` Andrew Cooper [this message]
2013-09-10 14:34 ` [PATCH 8/8] xenstored: fix possible, but unlikely, stack overflow Matthew Daley
2013-09-10 14:48 ` Andrew Cooper
2013-09-10 14:48 ` Ian Jackson
2013-09-13 12:31 ` [PATCH 0/8] Fixes for various minor Coverity issues Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F30AA.6050901@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mattjd@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.