All of lore.kernel.org
 help / color / mirror / Atom feed
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/5] dma: mmp_pdma: add support for residue reporting
Date: Tue, 10 Sep 2013 17:46:37 +0200	[thread overview]
Message-ID: <522F3EDD.20100@gmail.com> (raw)
In-Reply-To: <20130825180801.GY6617@n2100.arm.linux.org.uk>

On 25.08.2013 20:08, Russell King - ARM Linux wrote:
> On Wed, Aug 21, 2013 at 02:08:57PM +0200, Daniel Mack wrote:
>> @@ -750,6 +822,7 @@ static enum dma_status mmp_pdma_tx_status(struct dma_chan *dchan,
>>  
>>  	spin_lock_irqsave(&chan->desc_lock, flags);
>>  	ret = dma_cookie_status(dchan, cookie, txstate);
>> +	txstate->residue = mmp_pdma_residue(chan, cookie);
> 
> Please consider using dma_set_residue() here - it is legal to call the
> tx status function with a NULL txstate.
> 

Will do. Thanks for the hint.


Daniel

  reply	other threads:[~2013-09-10 15:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 12:08 [PATCH v5 0/5] dma: pdma: cyclic, residue, DMA_PRIVATE Daniel Mack
2013-08-21 12:08 ` [PATCH v5 1/5] dma: mmp_pdma: only complete one transaction from dma_do_tasklet() Daniel Mack
2013-08-21 12:08 ` [PATCH v5 2/5] dma: mmp_pdma: don't clear DCMD_ENDIRQEN at end of pending chain Daniel Mack
2013-08-21 12:08 ` [PATCH v5 3/5] dma: mmp_pdma: add support for cyclic DMA descriptors Daniel Mack
2013-08-21 12:08 ` [PATCH v5 4/5] dma: mmp_pdma: add support for residue reporting Daniel Mack
2013-08-25 16:33   ` Vinod Koul
2013-09-10 15:46     ` Daniel Mack
2013-09-13  4:51       ` Vinod Koul
2013-12-09 19:00         ` Daniel Mack
2013-12-10 16:11           ` Vinod Koul
2013-12-11 15:09             ` Daniel Mack
2013-08-25 18:08   ` Russell King - ARM Linux
2013-09-10 15:46     ` Daniel Mack [this message]
2013-08-21 12:08 ` [PATCH v5 5/5] dma: mmp_pdma: set DMA_PRIVATE Daniel Mack
2013-08-25 16:35 ` [PATCH v5 0/5] dma: pdma: cyclic, residue, DMA_PRIVATE Vinod Koul
2013-08-26  9:22   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522F3EDD.20100@gmail.com \
    --to=zonque@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.