From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 5/7] xen/arm: Fix assert in send_SGI_one Date: Tue, 10 Sep 2013 16:47:30 +0100 Message-ID: <522F3F12.9070108@linaro.org> References: <1377869433-15385-1-git-send-email-julien.grall@linaro.org> <1377869433-15385-6-git-send-email-julien.grall@linaro.org> <1378733410.19967.131.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378733410.19967.131.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/09/2013 02:30 PM, Ian Campbell wrote: > On Fri, 2013-08-30 at 14:30 +0100, Julien Grall wrote: >> The GIC can handle maximum 8 cpus (0...7). The CPU id 7 is still valid. >> >> Signed-off-by: Julien Grall >> --- >> xen/arch/arm/gic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c >> index 4f3a8a5..6dcefd7 100644 >> --- a/xen/arch/arm/gic.c >> +++ b/xen/arch/arm/gic.c >> @@ -481,7 +481,7 @@ void send_SGI_mask(const cpumask_t *cpumask, enum gic_sgi sgi) >> >> void send_SGI_one(unsigned int cpu, enum gic_sgi sgi) >> { >> - ASSERT(cpu < 7); /* Targets bitmap only supports 8 CPUs */ >> + ASSERT(cpu < NR_GIC_CPU_IF); /* Targets bitmap only supports 8 CPUs */ > > cpu here is a logical cpu id, not a gic id, I think? Right. > In which case although 8 happens to be correct: NR_GIC_CPU_IF is the > wrong thing to be using and in any case this seems against the general > principals of this series. NR_GIC_CPU_IF indicates the number of cpu interface handled by the GIC. Xen won't be able to register more than 8 CPUs, ie logical cpu id 0..7. >> send_SGI_mask(cpumask_of(cpu), sgi); >> } >> > > -- Julien Grall