From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v2 10/10] Warn cyclic buffer overrun and correct it if possible
Date: Wed, 11 Sep 2013 17:35:57 +0900 [thread overview]
Message-ID: <52302B6D.8060103@jp.fujitsu.com> (raw)
In-Reply-To: <52302103.5000304@mxc.nes.nec.co.jp>
(2013/09/11 16:51), Atsushi Kumagai wrote:
> Hello HATAYAMA-san,
>
> (2012/11/16 14:02), HATAYAMA Daisuke wrote:
>> Clearling bits on cyclic buffer can overrun the cyclic buffer
>> according to some combination of MAX_ORDER and cyclic buffer size.
>>
>> The cyclic buffer size is corrected if possible.
>>
>> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
>
> I know it's so late, I found that updating pfn_cyclic is missing.
> It can cause memory corruption.
>
Hello Kumagai-san,
Reviewed-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
It might be even better to introduce some kind of helper function that
sets up these cyclic-mode-related parameters and then to use it in
initial() and check_cyclic_buffer_overrun().
--
Thanks.
HATAYAMA, Daisuke
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-09-11 8:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 5:01 [PATCH v2 00/10] Support free page filtering looking up mem_map array HATAYAMA Daisuke
2012-11-16 5:01 ` [PATCH v2 01/10] Move page flags setup for old kernels after debuginfo initialization HATAYAMA Daisuke
2012-11-16 5:01 ` [PATCH v2 02/10] Add debuginfo interface for enum type size HATAYAMA Daisuke
2012-11-16 5:01 ` [PATCH v2 03/10] Add new parameters to various tables HATAYAMA Daisuke
2012-11-16 5:01 ` [PATCH v2 04/10] Add debuginfo-related processing for VMCOREINFO/VMLINUX HATAYAMA Daisuke
2012-11-16 5:01 ` [PATCH v2 05/10] Add hardcoded page flag values HATAYAMA Daisuke
2012-11-16 5:02 ` [PATCH v2 06/10] Exclude free pages by looking up mem_map array HATAYAMA Daisuke
2012-11-16 5:02 ` [PATCH v2 07/10] Add page_is_buddy for recent kernels HATAYAMA Daisuke
2012-11-16 5:02 ` [PATCH v2 08/10] Add page_is_buddy for PG_buddy HATAYAMA Daisuke
2012-11-27 6:00 ` Atsushi Kumagai
2012-11-27 7:30 ` Atsushi Kumagai
2012-11-27 8:53 ` Hatayama, Daisuke
2012-11-28 7:42 ` Atsushi Kumagai
2012-11-16 5:02 ` [PATCH v2 09/10] Add page_is_buddy for old kernels HATAYAMA Daisuke
2012-11-16 5:02 ` [PATCH v2 10/10] Warn cyclic buffer overrun and correct it if possible HATAYAMA Daisuke
2013-09-11 7:51 ` Atsushi Kumagai
2013-09-11 8:35 ` HATAYAMA Daisuke [this message]
2013-09-12 2:00 ` HATAYAMA Daisuke
2013-09-12 6:17 ` Atsushi Kumagai
2012-11-16 7:05 ` [PATCH v2 00/10] Support free page filtering looking up mem_map array Atsushi Kumagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52302B6D.8060103@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.