From: Paolo Bonzini <pbonzini@redhat.com>
To: famz@redhat.com
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net
Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules
Date: Wed, 11 Sep 2013 10:47:25 +0200 [thread overview]
Message-ID: <52302E1D.8030604@redhat.com> (raw)
In-Reply-To: <20130911083543.GB28040@T430s.nay.redhat.com>
Il 11/09/2013 10:35, Fam Zheng ha scritto:
>> > Since you'll have a v6, please move "all: modules" to Makefile, and in
>> > rules.mak:
>> >
>> > .PHONY: modules
>> > modules:
>> >
> Why is ".PHONY: modules" not in Makefile too?
I think you would need it even in Makefile.target, so I suggested rules.mak.
> And why do we need blank
> "modules:", with the real one generated above?
Just for clarity, since the target is declared only in a somewhat hidden
manner through $(eval).
Paolo
next prev parent reply other threads:[~2013-09-11 8:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 5:38 [Qemu-devel] [RFC PATCH v5 0/6] Shared Library Module Support Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 1/6] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-11 6:30 ` Paolo Bonzini
2013-09-11 7:05 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 2/6] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 3/6] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function Fam Zheng
2013-09-11 7:36 ` Paolo Bonzini
2013-09-11 14:10 ` Alex Bligh
2013-09-11 14:32 ` Paolo Bonzini
2013-09-11 15:06 ` Richard Henderson
2013-09-11 15:23 ` Alex Bligh
2013-09-11 15:43 ` Richard Henderson
2013-09-11 14:24 ` Peter Maydell
2013-09-12 3:12 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules Fam Zheng
2013-09-11 7:27 ` Paolo Bonzini
2013-09-11 7:41 ` Paolo Bonzini
2013-09-11 8:01 ` Gerd Hoffmann
2013-09-11 8:17 ` Fam Zheng
2013-09-11 8:20 ` Peter Maydell
2013-09-11 8:56 ` Gerd Hoffmann
2013-09-11 10:03 ` Peter Maydell
2013-09-11 10:37 ` Gerd Hoffmann
2013-09-11 10:58 ` Peter Maydell
2013-09-11 8:35 ` Fam Zheng
2013-09-11 8:47 ` Paolo Bonzini [this message]
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 6/6] block: build qed and curl as shared library Fam Zheng
2013-09-11 7:28 ` Paolo Bonzini
2013-09-11 7:36 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52302E1D.8030604@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.