From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 11 Sep 2013 13:12:45 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:12591 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822429Ab3IKLMmdE8pK (ORCPT ); Wed, 11 Sep 2013 13:12:42 +0200 Message-ID: <52304FD2.8030602@imgtec.com> Date: Wed, 11 Sep 2013 12:11:14 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Florian Fainelli CC: , , , Subject: Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT References: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com> In-Reply-To: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2013_09_11_12_12_36 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37784 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Florian On 11/09/13 11:34, Florian Fainelli wrote: > +vmlinuz: FORCE > + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'; \ > + /bin/false Nit: You don't really need the echo and /bin/false as part of the same command (i.e. the "; \" at end of echo), but no big deal. Reviewed-by: James Hogan Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:12591 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822429Ab3IKLMmdE8pK (ORCPT ); Wed, 11 Sep 2013 13:12:42 +0200 Message-ID: <52304FD2.8030602@imgtec.com> Date: Wed, 11 Sep 2013 12:11:14 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT References: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com> In-Reply-To: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Florian Fainelli Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, blogic@openwrt.org, richard@nod.at Message-ID: <20130911111114.TL9pswJaByEMIH3fh5v8Rt4LBkzf9KivmsexxcNVdvY@z> Hi Florian On 11/09/13 11:34, Florian Fainelli wrote: > +vmlinuz: FORCE > + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'; \ > + /bin/false Nit: You don't really need the echo and /bin/false as part of the same command (i.e. the "; \" at end of echo), but no big deal. Reviewed-by: James Hogan Cheers James