From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
Subject: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case
 no pool name is provided
Date: Wed, 11 Sep 2013 13:13:09 +0200
Message-ID: <52305045.90809@ts.fujitsu.com>
References: <20130911110612.14048.93476.stgit@hit-nxdomain.opendns.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130911110612.14048.93476.stgit@hit-nxdomain.opendns.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 11.09.2013 13:06, Dario Faggioli wrote:
> since it errors out, asking for at least one argument, and does
> not display any useful output, which is wrong (we want the list
> and the info about all the existing cpupools).
>
> IOW, the output is as follows:
>
>   ~# xl cpupool-list -c
>   'xl cpupool-list' requires at least 1 argument.
>   ...
>
> While it should be as follows:
>
>   ~# xl cpupool-list -c
>   Name               CPU list
>   Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>

> ---
>   tools/libxl/xl_cmdimpl.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 884f050..35b3e29 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
>       char *name;
>       int ret = 0;
>
> -    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
> +    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
>       case 'c':
>           opt_cpus = 1;
>           break;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
>


-- 
Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html