From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5230B93B.3040900@cogentembedded.com> Date: Wed, 11 Sep 2013 22:40:59 +0400 From: Sergei Shtylyov MIME-Version: 1.0 References: <1378745768-4495-1-git-send-email-cphealy@gmail.com> In-Reply-To: <1378745768-4495-1-git-send-email-cphealy@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Healy Cc: Stephen Hemminger , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , buytenh@wantstofly.org Hello. On 09/09/2013 08:56 PM, Chris Healy wrote: > This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification. You should wrap your changelog lines at 80 chars at most, preferably less. > With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age. > Tested successfully on bridge diameters of ~200. > Signed-off-by: Chris Healy WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/1] bridge: fix message_age_timer calculation Date: Wed, 11 Sep 2013 22:40:59 +0400 Message-ID: <5230B93B.3040900@cogentembedded.com> References: <1378745768-4495-1-git-send-email-cphealy@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , buytenh@wantstofly.org To: Chris Healy Return-path: In-Reply-To: <1378745768-4495-1-git-send-email-cphealy@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org Hello. On 09/09/2013 08:56 PM, Chris Healy wrote: > This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification. You should wrap your changelog lines at 80 chars at most, preferably less. > With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age. > Tested successfully on bridge diameters of ~200. > Signed-off-by: Chris Healy WBR, Sergei