Re: [PATCH 04/11] tegrarcm: Add Tegra124 support

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 09/11/2013 02:49 PM, Allen Martin wrote:
> On Mon, Sep 09, 2013 at 02:38:47PM -0700, Stephen Warren wrote:
>> On 09/09/2013 02:15 PM, Allen Martin wrote:
>>> Add Tegra124 USB device id, miniloader, and chip SKU information.
>>
>>> @@ -481,6 +491,11 @@ static void dump_platform_info(nv3p_platform_info_t *info)
>>>  		case TEGRA114_CHIP_SKU_T114: chip_name = "t114"; break;
>>>  		default: chip_name = "unknown"; break;
>>>  		}
>>> +	} else if (info->chip_id.id == 0x40) {
>>> +		switch (info->sku) {
>>> +		case TEGRA124_CHIP_SKU_T124: chip_name = "t124"; break;
>>> +		default: chip_name = "unknown"; break;
>>> +		}
>>>  	} else {
>>>  		chip_name = "unknown";
>>>  	}
>>
>> Do we really need to care about the SKU here? For chips other than
>> Tegra20, can't we just switch on the chip ID and be done with it? The
>> reason I ask is that in U-Boot, there are some SKU IDs that haven't been
>> ported into tegrarcm, and I assume we should be keeping the two SKU ID
>> lists in sync. It'd be simpler if we just made tegrarcm not care about SKU.
> 
> It's purely informative as we don't do anything with the information
> elsewhere in tegrarcm.  Maybe I should just make the default be the
> chip family instead of "unknown" so it's more resistant to being out
> of sync (and also take a pass at syncing up with u-boot) ?

Sounds good to me.