From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V2] x86/AMD-Vi: Add additional check for invalid special->handle Date: Wed, 11 Sep 2013 17:31:18 -0500 Message-ID: <5230EF36.6030103@amd.com> References: <1377711297-2705-1-git-send-email-suravee.suthikulpanit@amd.com> <521F11B602000078000EF4ED@nat28.tlf.novell.com> <521FAE67.7080309@amd.com> <52206EA002000078000EFA11@nat28.tlf.novell.com> <52210208.9000809@amd.com> <5227204102000078000F0474@nat28.tlf.novell.com> <5227B8C3.2060802@amd.com> <52284B8502000078000F0A75@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52284B8502000078000F0A75@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org, keir@xen.org, linux@eikelenboom.it List-Id: xen-devel@lists.xenproject.org On 9/5/2013 2:14 AM, Jan Beulich wrote: >>>> On 05.09.13 at 00:48, Suravee Suthikulpanit wrote: >> On 9/4/2013 4:57 AM, Jan Beulich wrote: >>> It would, btw, be possible to get along with a single command line >>> option, just having two alternating forms: >>> >>> ivrs_ioapic[id]= >>> ivrs_ioapic[]= >> After looking through the examples above, I still think we only need the >> "ivrs_ioapic[]=" version. > Perhaps, but then could you talk to your Linux side colleagues to > find out why they picked (only) the other alternative? I'd really > like to keep such workarounds largely in sync (a superset is fine, > but a subset, not to speak of a disjoint set, are not) with Linux... > > Jan At this point, I think it's mainly syntax. Since the implementation is different. If you want to keep the syntax the same (i.e. ivrs_ioapic[id]=), we can do that. I don't think Linux tries to interpret as "pin id" or "pin sdbf". All it does is just ties both values together. Suravee