From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK2J9-0001Ur-MR for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:31:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK2J4-0007I1-Lo for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:31:23 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:20669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK2J4-0007Hw-Cc for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:31:18 -0400 Message-ID: <52317BBB.9040009@huawei.com> Date: Thu, 12 Sep 2013 10:30:51 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1378144503-15808-1-git-send-email-rth@twiddle.net> <1378144503-15808-4-git-send-email-rth@twiddle.net> In-Reply-To: <1378144503-15808-4-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 02.09.2013 19:54, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 20 +++++++------------- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index bde4c72..79a447d 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > args[0], args[1], args[2]); > break; > > - case INDEX_op_mov_i64: > - case INDEX_op_mov_i32: > - tcg_out_movr(s, ext, args[0], args[1]); > - break; > - > - case INDEX_op_movi_i64: > - tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]); > - break; > - case INDEX_op_movi_i32: > - tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]); > - break; > - > case INDEX_op_add_i64: > case INDEX_op_add_i32: > tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0); > @@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > tcg_out_movr(s, 0, args[0], args[1]); > break; > > + case INDEX_op_mov_i64: > + case INDEX_op_mov_i32: > + case INDEX_op_movi_i64: > + case INDEX_op_movi_i32: > + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ > default: > - tcg_abort(); /* opcode not implemented */ > + /* Opcode not implemented. */ > + tcg_abort(); > } > } > Ok -- Claudio Fontana Server OS Architect Huawei Technologies Duesseldorf GmbH Riesstraße 25 - 80992 München office: +49 89 158834 4135 mobile: +49 15253060158