From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources Date: Thu, 12 Sep 2013 15:28:23 +0530 Message-ID: <5231903F.7080301@ti.com> References: <1378839171-14455-1-git-send-email-joelf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378839171-14455-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Joel Fernandes Cc: Linux DaVinci Kernel List , Russell King , Vinod Koul , Pantel Antoniou , Linux MMC List , Koen Kooi , Jyri Sarah , Linux Kernel Mailing List , Jason Kridner , Dan Williams , Linux OMAP List , Linux ARM Kernel List List-Id: linux-mmc@vger.kernel.org On Wednesday 11 September 2013 12:22 AM, Joel Fernandes wrote: > HWMOD removal for MMC is breaking edma_start as the events are being manually > triggered due to unused channel list not being clear. > > This patch fixes the issue, by reading the "dmas" property from the DT node if > it exists and clearing the bits in the unused channel list. For this purpose > we use the of_* helpers to parse the arguments in the dmas phandle list. > > Reviewed-by: Sekhar Nori > Reported-by: Balaji T K > Cc: Pantel Antoniou > Signed-off-by: Joel Fernandes > --- > This patch is a repost of v2 with minor change of return value. Is this patch meant for merging? If yes, I see no resolution of the comments given in this thread: https://lkml.org/lkml/2013/7/30/9 It is better to send one version with all comments fixed. Helps avoid confusion. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Thu, 12 Sep 2013 15:28:23 +0530 Subject: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources In-Reply-To: <1378839171-14455-1-git-send-email-joelf@ti.com> References: <1378839171-14455-1-git-send-email-joelf@ti.com> Message-ID: <5231903F.7080301@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 11 September 2013 12:22 AM, Joel Fernandes wrote: > HWMOD removal for MMC is breaking edma_start as the events are being manually > triggered due to unused channel list not being clear. > > This patch fixes the issue, by reading the "dmas" property from the DT node if > it exists and clearing the bits in the unused channel list. For this purpose > we use the of_* helpers to parse the arguments in the dmas phandle list. > > Reviewed-by: Sekhar Nori > Reported-by: Balaji T K > Cc: Pantel Antoniou > Signed-off-by: Joel Fernandes > --- > This patch is a repost of v2 with minor change of return value. Is this patch meant for merging? If yes, I see no resolution of the comments given in this thread: https://lkml.org/lkml/2013/7/30/9 It is better to send one version with all comments fixed. Helps avoid confusion. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757861Ab3ILKD3 (ORCPT ); Thu, 12 Sep 2013 06:03:29 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40121 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534Ab3ILKD1 (ORCPT ); Thu, 12 Sep 2013 06:03:27 -0400 Message-ID: <5231903F.7080301@ti.com> Date: Thu, 12 Sep 2013 15:28:23 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Joel Fernandes CC: Matt Porter , Vinod Koul , Dan Williams , Russell King , Jyri Sarah , Jason Kridner , Koen Kooi , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux MMC List , Pantel Antoniou Subject: Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources References: <1378839171-14455-1-git-send-email-joelf@ti.com> In-Reply-To: <1378839171-14455-1-git-send-email-joelf@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 September 2013 12:22 AM, Joel Fernandes wrote: > HWMOD removal for MMC is breaking edma_start as the events are being manually > triggered due to unused channel list not being clear. > > This patch fixes the issue, by reading the "dmas" property from the DT node if > it exists and clearing the bits in the unused channel list. For this purpose > we use the of_* helpers to parse the arguments in the dmas phandle list. > > Reviewed-by: Sekhar Nori > Reported-by: Balaji T K > Cc: Pantel Antoniou > Signed-off-by: Joel Fernandes > --- > This patch is a repost of v2 with minor change of return value. Is this patch meant for merging? If yes, I see no resolution of the comments given in this thread: https://lkml.org/lkml/2013/7/30/9 It is better to send one version with all comments fixed. Helps avoid confusion. Thanks, Sekhar