From: Vlad Yasevich <vyasevic@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Hong zhi guo <honkiko@gmail.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
zhiguohong@tencent.com
Subject: Re: [PATCH net-next] fix NULL pointer dereference in br_handle_frame
Date: Thu, 12 Sep 2013 10:42:26 -0400 [thread overview]
Message-ID: <5231D2D2.3090907@redhat.com> (raw)
In-Reply-To: <1378996396.24408.8.camel@edumazet-glaptop>
On 09/12/2013 10:33 AM, Eric Dumazet wrote:
> On Thu, 2013-09-12 at 22:24 +0800, Hong zhi guo wrote:
>> You mean IFF_BRIDGE_PORT should be only for admin/control path, but
>> not for data path?
>
> By definition, br_handle_frame() should be called only when device is a
> bridge port.
>
> After the call to synchronize_net() included in
> netdev_rx_handler_unregister(), you have guarantee br_handle_frame()
> wont be called.
>
> Therefore, testing IFF_BRIDGE_PORT in br_handle_frame() is redundant.
Don't all tests for IFF_BRIDGE_PORT on the bridge receive path become
redundant as well?
-vlad
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-09-12 14:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:16 [PATCH net-next] fix NULL pointer dereference in br_handle_frame Hong Zhiguo
2013-09-12 14:11 ` Eric Dumazet
2013-09-12 14:24 ` Hong zhi guo
2013-09-12 14:33 ` Eric Dumazet
2013-09-12 14:42 ` Vlad Yasevich [this message]
2013-09-12 15:24 ` Eric Dumazet
2013-09-12 15:50 ` Vlad Yasevich
2013-09-12 16:08 ` Eric Dumazet
2013-09-12 15:57 ` Hong Zhiguo
2013-09-12 16:06 ` Hong zhi guo
2013-09-12 16:11 ` Eric Dumazet
2013-09-12 16:18 ` Hong zhi guo
2013-09-12 16:19 ` Eric Dumazet
2013-09-12 16:12 ` Eric Dumazet
2013-09-12 19:18 ` David Miller
2013-09-13 3:09 ` [PATCH net-next] bridge: fix NULL pointer deref " Hong Zhiguo
2013-09-13 16:21 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5231D2D2.3090907@redhat.com \
--to=vyasevic@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zhiguohong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.