From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d
Date: Thu, 12 Sep 2013 18:31:55 +0200 [thread overview]
Message-ID: <5231EC7B.1050207@redhat.com> (raw)
In-Reply-To: <20130909120750.GA20923@stefanha-thinkpad.redhat.com>
Il 09/09/2013 14:07, Stefan Hajnoczi ha scritto:
> On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote:
>> KVM request types are normally defined using hex constants but QEMU traces
>> print decimal values instead, which is not very convenient.
>>
>> This changes the request type format from %d to %x.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> Changes:
>> v2:
>> * added "0x" to format strings so the change won't come unnoticed
>> * fixed the commit message
>> ---
>> trace-events | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
Applied also to uq/master, since I don't see it in github.
Paolo
prev parent reply other threads:[~2013-09-12 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 10:26 [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
2013-09-09 12:07 ` Stefan Hajnoczi
2013-09-12 16:31 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5231EC7B.1050207@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.