All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, chao.zhou@intel.com
Subject: Re: [PATCH] KVM: nEPT: reset PDPTR register cache on nested vmentry emulation
Date: Thu, 12 Sep 2013 18:33:16 +0200	[thread overview]
Message-ID: <5231ECCC.4050401@redhat.com> (raw)
In-Reply-To: <20130902122527.GS22899@redhat.com>

Il 02/09/2013 14:25, Gleb Natapov ha scritto:
> After nested vmentry stale cache can be used to reload L2 PDPTR pointers
> which will cause L2 guest to fail. Fix it by invalidating cache on nested
> vmentry emulation.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=60830
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 57b4e12..6f69aac 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7765,6 +7765,10 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>  		vmcs_write64(GUEST_PDPTR1, vmcs12->guest_pdptr1);
>  		vmcs_write64(GUEST_PDPTR2, vmcs12->guest_pdptr2);
>  		vmcs_write64(GUEST_PDPTR3, vmcs12->guest_pdptr3);
> +		__clear_bit(VCPU_EXREG_PDPTR,
> +				(unsigned long *)&vcpu->arch.regs_avail);
> +		__clear_bit(VCPU_EXREG_PDPTR,
> +				(unsigned long *)&vcpu->arch.regs_dirty);
>  	}
>  
>  	kvm_register_write(vcpu, VCPU_REGS_RSP, vmcs12->guest_rsp);
> --
> 			Gleb.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Applied to kvm/queue for 3.12, thanks.

Paolo

      reply	other threads:[~2013-09-12 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02 12:25 [PATCH] KVM: nEPT: reset PDPTR register cache on nested vmentry emulation Gleb Natapov
2013-09-12 16:33 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5231ECCC.4050401@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=chao.zhou@intel.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.