All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Frank Schäfer" <fschaefer.oss@googlemail.com>
Subject: Re: [RFD] use-counting V4L2 clocks
Date: Thu, 12 Sep 2013 22:47:28 +0200	[thread overview]
Message-ID: <52322860.30106@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309121947590.7038@axis700.grange>

Hi Guennadi,

On 09/12/2013 09:13 PM, Guennadi Liakhovetski wrote:
> So, I think, our V4L2 clock enable / disable calls should be balanced, and
> to enforce that a warning is helpful. Other opinions?

I'd assume we should enforce those calls balanced, but I might not be
well aware of consequences for the all existing drivers. AFAIR all drivers
used in embedded systems follow the convention where default power state
is off and the s_power() calls are balanced.

I never ventured much into drivers that originally used tuner.s_standby()
before it got renamed to core.s_power(). As Mauro indicated tuner devices
assume default device power ON state, but additional s_power(1) call should
not break things as Frank pointed out.

I'd say let's make s_power(1) calls balanced, keep the warning and revisit
drivers one by one as they get support for explicit clock control added.

--
Regards,
Sylwester

  reply	other threads:[~2013-09-12 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 19:13 [RFD] use-counting V4L2 clocks Guennadi Liakhovetski
2013-09-12 20:47 ` Sylwester Nawrocki [this message]
2013-10-08 17:13   ` Guennadi Liakhovetski
2013-10-08 20:33 ` Mauro Carvalho Chehab
2013-10-08 21:57   ` Guennadi Liakhovetski
2013-10-10  0:06     ` Laurent Pinchart
2013-10-15  8:05       ` Guennadi Liakhovetski
2013-10-15 11:45         ` Laurent Pinchart
2013-10-15 21:37           ` Guennadi Liakhovetski
2013-10-19 21:44             ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52322860.30106@gmail.com \
    --to=sylvester.nawrocki@gmail.com \
    --cc=fschaefer.oss@googlemail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.