From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A7DDCD1284 for ; Thu, 4 Apr 2024 19:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rD9jovA/u18Z6KUNslh8nfrK15FwY7F7yrq1OAprZDc=; b=EidXyOtzE61Kh4 ZrdeCAuIYbk98Luq/EInHjrNTwQHWz/R6Tz7oPOoiViBXobj+d5owwEsAUUlR6g8L8UTnf4sI8lc5 CLvHiFv5iZKJRl075b+DOqQJxoTo0JvMX3HSQoCcr5ZqlM2gwg2a4JG0qQFkyMPxy5ZIueOAUSHjj 4Glo07c95UqNwLOttt2Z/OHnFPcN0nJyU4XaS72GWJC4efEyPW+9jGVqj/ZLi8FqmoclgFEmv2emJ vASNcDSobJ37mpeFJv5zX9Lue2DnIjHAqOTTiL43baN3k30dvIEBsQMLO5K0WkJyG9JzJJt2F5T2A /0TlPJQ6k+rc6v/+vG1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsSjj-0000000436r-2yrb; Thu, 04 Apr 2024 19:26:59 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsSjh-0000000434w-1TYR; Thu, 04 Apr 2024 19:26:58 +0000 Received: from i53875aaf.versanet.de ([83.135.90.175] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsSjZ-0005PO-AW; Thu, 04 Apr 2024 21:26:49 +0200 From: Heiko Stuebner To: Vinod Koul , Kishon Vijay Abraham I , Sebastian Reichel Cc: Shawn Lin , Michal Tomek , linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 2/3] phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits Date: Thu, 04 Apr 2024 21:26:48 +0200 Message-ID: <5232346.31r3eYUQgx@phil> In-Reply-To: <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> References: <20240404-rk3588-pcie-bifurcation-fixes-v1-0-9907136eeafd@kernel.org> <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_122657_421145_80C0C298 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Am Donnerstag, 4. April 2024, 19:11:27 CEST schrieb Sebastian Reichel: > From: Sebastian Reichel > > Currently the PCIe v3 PHY driver only sets the pcie1ln_sel bits, but > does not clear them because of an incorrect write mask. This fixes up > the issue by using a newly introduced constant for the write mask. > > While at it also introduces a proper GENMASK based constant for the > PCIE30_PHY_MODE. > > Fixes: 2e9bffc4f713 ("phy: rockchip: Support PCIe v3") > Signed-off-by: Sebastian Reichel after checking with the soc manual Reviewed-by: Heiko Stuebner -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD857CD1284 for ; Thu, 4 Apr 2024 19:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ibWgHzuJVvDUipu+V0btqWg1nOJ/xM67QohiwxaKqM=; b=XsJShvaVT1x/Zs LrM/XkApGeJPzrhyH6d1VFT4cF02vXAwlHHrAsiBSa3vvPMJz/RlQFlHazKZ0jJe0LRhSjLA+Y/DU NhIdACa8YOU+2EgM0YNxv/vTTeOuojEtD1BBr8yCJ9HW39Se0Qey98AF9KC+HkavtEVj/bdi+Pskd 2LK/fvB2IVMrB7einJz+YdPay8WQGOnFOj7RprAVrQnylGjMXW2l0EEwQqYaB732jBqeJ/QZZQWCH ShyrPWl6ITL9GcjwhB2PXmY4kSNYoDVkRUiG9TdJ0QtFH9i2572+Qapq+oC1N16V9UvacSfrjlA/E l7aVmWVejHXZzbxa2oFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsSjk-0000000437F-0kiz; Thu, 04 Apr 2024 19:27:00 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsSjh-0000000434w-1TYR; Thu, 04 Apr 2024 19:26:58 +0000 Received: from i53875aaf.versanet.de ([83.135.90.175] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsSjZ-0005PO-AW; Thu, 04 Apr 2024 21:26:49 +0200 From: Heiko Stuebner To: Vinod Koul , Kishon Vijay Abraham I , Sebastian Reichel Cc: Shawn Lin , Michal Tomek , linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 2/3] phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits Date: Thu, 04 Apr 2024 21:26:48 +0200 Message-ID: <5232346.31r3eYUQgx@phil> In-Reply-To: <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> References: <20240404-rk3588-pcie-bifurcation-fixes-v1-0-9907136eeafd@kernel.org> <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_122657_421145_80C0C298 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Donnerstag, 4. April 2024, 19:11:27 CEST schrieb Sebastian Reichel: > From: Sebastian Reichel > > Currently the PCIe v3 PHY driver only sets the pcie1ln_sel bits, but > does not clear them because of an incorrect write mask. This fixes up > the issue by using a newly introduced constant for the write mask. > > While at it also introduces a proper GENMASK based constant for the > PCIE30_PHY_MODE. > > Fixes: 2e9bffc4f713 ("phy: rockchip: Support PCIe v3") > Signed-off-by: Sebastian Reichel after checking with the soc manual Reviewed-by: Heiko Stuebner _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DA54134730 for ; Thu, 4 Apr 2024 19:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712258821; cv=none; b=AIGlyhHLjVuB3W1ElQkw6GQ18lzAGvOE/Rayx1eR58pycZVIgbznjSxB5PAvFvo4IMbUKdNg+v+Dvzvnmq9AMsnhphlZn1bdZR1kxeC0hWTFEnIzNQMAFtQZU3SGHL4QVP77/PzVMgCDjFsnOHAzI6HHRHaQ2Xxg5DqXypks5Vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712258821; c=relaxed/simple; bh=DN3Rl/VGAC+TFPGwzkMs2CopD6q2AYSDbcJFPFL9loU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PoRyaZ7QcCbZb03CeU1UpKl4gQ30Cd44MGf26CwfnJq7yDIoscf/n9sN9QoqID+TwuXIHG7XDUPXtebPPhS4v8X7GzR3zquxRPapkwFjTS0D4+ZIDy9wtn6w1wQfAtRiaduOjoOy6kfTjZqHYLazVUaFQAjnpmUnyChGhuRG3Uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875aaf.versanet.de ([83.135.90.175] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsSjZ-0005PO-AW; Thu, 04 Apr 2024 21:26:49 +0200 From: Heiko Stuebner To: Vinod Koul , Kishon Vijay Abraham I , Sebastian Reichel Cc: Shawn Lin , Michal Tomek , linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 2/3] phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits Date: Thu, 04 Apr 2024 21:26:48 +0200 Message-ID: <5232346.31r3eYUQgx@phil> In-Reply-To: <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> References: <20240404-rk3588-pcie-bifurcation-fixes-v1-0-9907136eeafd@kernel.org> <20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Donnerstag, 4. April 2024, 19:11:27 CEST schrieb Sebastian Reichel: > From: Sebastian Reichel > > Currently the PCIe v3 PHY driver only sets the pcie1ln_sel bits, but > does not clear them because of an incorrect write mask. This fixes up > the issue by using a newly introduced constant for the write mask. > > While at it also introduces a proper GENMASK based constant for the > PCIE30_PHY_MODE. > > Fixes: 2e9bffc4f713 ("phy: rockchip: Support PCIe v3") > Signed-off-by: Sebastian Reichel after checking with the soc manual Reviewed-by: Heiko Stuebner