From: Lars-Peter Clausen <lars@metafoo.de>
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v2] MIPS: GIC: Select R4K counter as fallback.
Date: Fri, 13 Sep 2013 09:52:29 +0200 [thread overview]
Message-ID: <5232C43D.7050503@metafoo.de> (raw)
In-Reply-To: <523206B9.6000201@imgtec.com>
On 09/12/2013 08:23 PM, Leonid Yegoshin wrote:
> On 09/12/2013 12:28 AM, Lars-Peter Clausen wrote:
>> On 09/11/2013 09:51 PM, Steven J. Hill wrote:
>>> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>>>
>>> If CONFIG_CSRC_GIC is selected and the GIC is not found during
>>> boot, then fallback to the R4K counter gracefully.
>> Is there any reason not to always register the r4k clocksource, no matter
>> whether the gic clocksource is present or not? The timekeeping core of the
>> kernel will make sure to use the best available clocksource based on the
>> clocksource's rating.
>>
>> - Lars
> If you do power saving by switching some core OFF then you should do an
> additional clock sync after core revival.
> GIC is free from that but R4K is not. It was a primary reason for GIC
> clocksource.
Ok, but what I was saying is that there is no need to not register the r4k
clocksource if the gic clocksource is present since the kernel can deal with
multiple registered clocksources just fine. This is not a problem that needs
to be solved in MIPS specific code, if the rating for the clocksources is
set properly the kernel will switch to the gic clocksource as soon as it is
registered and ignore the r4k clocksource. No need to do any reference to
the gic in the r4k clocksource code.
- Lars
prev parent reply other threads:[~2013-09-13 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 19:51 [PATCH v2] MIPS: GIC: Select R4K counter as fallback Steven J. Hill
2013-09-12 6:34 ` John Crispin
2013-09-12 7:28 ` Lars-Peter Clausen
2013-09-12 7:33 ` John Crispin
2013-09-12 7:38 ` Lars-Peter Clausen
2013-09-12 8:04 ` John Crispin
2013-09-12 18:23 ` Leonid Yegoshin
2013-09-12 18:23 ` Leonid Yegoshin
2013-09-13 7:52 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5232C43D.7050503@metafoo.de \
--to=lars@metafoo.de \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.