From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
robdclark@gmail.com, devicetree@vger.kernel.org,
Andy Gross <andygro@gmail.com>
Subject: Re: [PATCH 1/4] arm: omap: display: Create omapdrm inside omap_display_init
Date: Fri, 13 Sep 2013 15:08:06 +0530 [thread overview]
Message-ID: <5232DCFE.5050700@ti.com> (raw)
In-Reply-To: <5232D9C8.9020809@ti.com>
On Friday 13 September 2013 02:54 PM, Tomi Valkeinen wrote:
> On 13/09/13 12:14, Archit Taneja wrote:
>> Move omapdrm device creation inside the omap_display_init so that we can
>> correctly create the device based on the presence of omapdss.
>>
>> Originally worked on by Andy Gross.
>
> If the dmm device is present in the DT data, there is no need to create
> the dmm device. It's created automatically.
Yes, that is done in a later patch.
>
> Also, omapfb device is currently created the same way as omapdrm,
> independently of omapdss. Why is it a problem to have them like that?
In a multiplatform config, we might have CONFIG_DRM_OMAP and
CONFIG_DRM_OMAP_MODULE selected.
This would cause the call omap_init_drm() in arch/arm/mach-omap2/drm.c
to occur. Creating a platform device for omapdrm is unnecessary here
isn't it? Tying it with the initialisation of omapdss devices prevents it.
Archit
next prev parent reply other threads:[~2013-09-13 9:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 9:14 [PATCH 0/4] arm: omap: DMM DT adaptation Archit Taneja
2013-09-13 9:14 ` [PATCH 1/4] arm: omap: display: Create omapdrm inside omap_display_init Archit Taneja
[not found] ` <1379063679-4869-2-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:24 ` Tomi Valkeinen
2013-09-13 9:38 ` Archit Taneja [this message]
[not found] ` <5232DCFE.5050700-l0cyMroinI0@public.gmane.org>
2013-09-13 9:39 ` Archit Taneja
[not found] ` <5232DD53.3010706-l0cyMroinI0@public.gmane.org>
2013-09-13 9:48 ` Tomi Valkeinen
[not found] ` <5232DF61.6000109-l0cyMroinI0@public.gmane.org>
2013-09-13 9:51 ` Archit Taneja
2013-09-13 10:02 ` Tomi Valkeinen
2013-09-13 10:17 ` Archit Taneja
2013-09-13 10:24 ` Tomi Valkeinen
[not found] ` <5232E7E2.7050606-l0cyMroinI0@public.gmane.org>
2013-09-13 10:32 ` Archit Taneja
2013-09-13 9:42 ` Tomi Valkeinen
[not found] ` <1379063679-4869-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:14 ` [PATCH 2/4] ARM: dts: OMAP4+: Add DMM bindings Archit Taneja
2013-09-13 9:14 ` [PATCH 3/4] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379063679-4869-4-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 14:14 ` Rob Clark
[not found] ` <CAF6AEGu7eRFhrQZUD-43AOHNQtRWeyxYga1dnir=qUo1mQ9ebA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-16 6:28 ` Archit Taneja
[not found] ` <5236A503.90507-l0cyMroinI0@public.gmane.org>
2013-09-16 11:56 ` Rob Clark
2013-09-13 9:14 ` [PATCH 4/4] arm: omap: display: Don't build device " Archit Taneja
[not found] ` <1379063679-4869-5-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:29 ` Tomi Valkeinen
2013-09-16 9:30 ` [PATCH v2 0/2] DMM DT adaptation Archit Taneja
2013-09-16 9:30 ` [PATCH v2 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-09-16 11:19 ` Tomi Valkeinen
[not found] ` <5236E940.9070503-l0cyMroinI0@public.gmane.org>
2013-09-16 12:25 ` Archit Taneja
2013-09-16 9:30 ` [PATCH v2 2/2] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379323815-14130-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-16 11:30 ` [PATCH v2 0/2] DMM DT adaptation Tomi Valkeinen
2013-10-10 6:36 ` [PATCH v3 " Archit Taneja
2013-10-10 6:36 ` [PATCH v3 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-10-10 10:08 ` Mark Rutland
2013-10-10 10:36 ` Archit Taneja
2013-10-10 6:36 ` [PATCH v3 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-10-15 7:04 ` [PATCH v4 0/2] DMM DT adaptation Archit Taneja
2013-10-15 7:04 ` [PATCH v4 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-11 7:15 ` Tomi Valkeinen
2014-03-11 8:14 ` Archit Taneja
2013-10-15 7:04 ` [PATCH v4 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-11-01 0:40 ` Mark Rutland
2013-11-05 5:50 ` Archit Taneja
2013-12-17 10:02 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2013-12-17 10:02 ` [PATCH v5 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-02 19:53 ` Benoit Cousson
2013-12-17 10:02 ` [PATCH v5 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2014-01-03 12:34 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2014-01-17 7:32 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5232DCFE.5050700@ti.com \
--to=archit@ti.com \
--cc=andygro@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.