All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks
Date: Fri, 13 Sep 2013 18:49:10 +0800	[thread overview]
Message-ID: <5232EDA6.6060902@oracle.com> (raw)
In-Reply-To: <20130912163629.GD6810@twin.jikos.cz>


> Thanks for implementing it! I found a few things to fix, comments below.
>
> I wonder if we should keep --all-devices as a last resort fallback eg.

  Any idea whats the real use of --all-devices option anyway
  I am unsure. Anyway will restore --all-devices so now.

  all other suggestion were considered as well.

> I see this warning and there are no mounted filesystems listed in the
> output:
>
> $ ./btrfs fi show
> ERROR: scan kernel failed, -1
>

when does this happen ? I can't reproduce it.

Thanks, Anand

  reply	other threads:[~2013-09-13 10:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  8:35 [PATCH 0/2] v2, fi show, dev scan and lblkid Anand Jain
2013-08-30  8:35 ` [PATCH 1/2] btrfs-progs: v4, move out print in cmd_df to another function Anand Jain
2013-08-30  8:35 ` [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
2013-09-06  9:37 ` [PATCH 1/2 resend] btrfs-progs: v4, move out print in cmd_df to another function Anand Jain
2013-09-06  9:37   ` [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
2013-09-12 16:36     ` David Sterba
2013-09-13 10:49       ` Anand Jain [this message]
2013-09-13 15:56         ` David Sterba
2013-09-13 16:21           ` David Sterba
2013-09-12 15:42   ` [PATCH 1/2 resend] btrfs-progs: v4, move out print in cmd_df to another function David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5232EDA6.6060902@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.