From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKZQI-0005cd-0n for qemu-devel@nongnu.org; Fri, 13 Sep 2013 15:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKZQD-00071v-4n for qemu-devel@nongnu.org; Fri, 13 Sep 2013 15:52:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKZQC-00071g-S1 for qemu-devel@nongnu.org; Fri, 13 Sep 2013 15:52:53 -0400 Message-ID: <52336D0C.9040307@redhat.com> Date: Fri, 13 Sep 2013 13:52:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379067909-22984-1-git-send-email-pl@kamp.de> <1379067909-22984-9-git-send-email-pl@kamp.de> <5232EA90.7030903@redhat.com> <523358AF.9000504@redhat.com> <52336C21.2050902@kamp.de> In-Reply-To: <52336C21.2050902@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6WvngpGXvNudE0FRJFPHdMrIcDxLUNAUQ" Subject: Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6WvngpGXvNudE0FRJFPHdMrIcDxLUNAUQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2013 01:48 PM, Peter Lieven wrote: >>>> + flags =3D BDRV_O_RDWR | BDRV_O_UNMAP; >>> I think this should be a new command-line flag. >> I agree - while 'sparse by default' may be reasonable, it is also >> feasible to want a mode that guarantees expansion rather than unmapped= >> or sparse. >> > Ok, so do you find the proposed -S 0 bei Paolo a good choice? > If this is supplied I would go as far as completly setting > has_zero_init =3D 0 also for targets which default to 1. This > would guaranteed exspansion and full allocation for all drivers. Yeah, works for me - an optional mode that guarantees full allocation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6WvngpGXvNudE0FRJFPHdMrIcDxLUNAUQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSM20MAAoJEKeha0olJ0NqaGMH/0VQ1shQC32LMfmZlJ0np/2h cmoTYRepRTHskxoorak2LY1HEWgrqGHLtpU7W6OORInUbFXI7b6fmLz6TWRRQtTF Y0gQZkaFbfJYKSvOx/grvjSetyK7ZmuSkNvxefV75isQrEgrsYfYecTzL6s3KPQW uN8INUzDv9hdfmz3ixbGY4d08daEuR9s8QIDOAXKTj9KujZP3/ZaSOt5VICaowdQ 0gS1u2GbfqKOqknxRMi2+LEywGWsyLc0JOOf6cmKDevuG7dAE5tLFpo+eJ8knQ40 l0DpnT6NbjzHrPi62N1yhwtsDFRPDrLaW+lUXwvqide4XpInOEY9IX6PYzFLRDY= =2Zdf -----END PGP SIGNATURE----- --6WvngpGXvNudE0FRJFPHdMrIcDxLUNAUQ--