From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] Documentation: DT: arm: define CPU topology bindings
Date: Fri, 13 Sep 2013 16:07:11 -0500 [thread overview]
Message-ID: <52337E7F.9010802@gmail.com> (raw)
In-Reply-To: <1376559743-31848-3-git-send-email-lorenzo.pieralisi@arm.com>
On 08/15/2013 04:42 AM, Lorenzo Pieralisi wrote:
> The advent of multi-cluster ARM systems requires a mechanism to describe
> how in hierarchical terms CPUs are connected in ARM SoCs so that the kernel
> can initialize and map resources like IRQs and memory space to specific
> group(s) of CPUs.
>
> The CPU topology is made up of multiple hierarchy levels whose bottom
> layers (aka leaf nodes in device tree syntax) contain links to the HW
> CPUs in the system.
>
> The topology bindings are generic for both 32-bit and 64-bit systems and
> lay the groundwork on top of which affinity schemes can be built.
By affinity schemes, you mean further bindings? Do we need this binding
until that point?
As is, I don't have much comment.
[snip]
> +Example 3 (ARM 32-bit, cortex-a8 single core):
> +
> +cpus {
> + #size-cells = <0>;
> + #address-cells = <1>;
> +
> + cpu-map {
> + cluster0 {
> + core0 {
> + cpu = <&CPU0>;
> + };
> + };
> + };
This example seems utterly pointless. I think we should be specific that
single core does not contain a cpu-map. I suppose we could have a
threaded, single core case, but let's address that if we ever do.
Rob
> +
> + CPU0: cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a8";
> + reg = <0x0>;
> + };
> +};
> +
> +===============================================================================
> +[1] ARM Linux kernel documentation
> + Documentation/devicetree/bindings/arm/cpus.txt
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Dave Martin <dave.martin-5wv7dgnIgG8@public.gmane.org>,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
Hanjun Guo <hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 2/2] Documentation: DT: arm: define CPU topology bindings
Date: Fri, 13 Sep 2013 16:07:11 -0500 [thread overview]
Message-ID: <52337E7F.9010802@gmail.com> (raw)
In-Reply-To: <1376559743-31848-3-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
On 08/15/2013 04:42 AM, Lorenzo Pieralisi wrote:
> The advent of multi-cluster ARM systems requires a mechanism to describe
> how in hierarchical terms CPUs are connected in ARM SoCs so that the kernel
> can initialize and map resources like IRQs and memory space to specific
> group(s) of CPUs.
>
> The CPU topology is made up of multiple hierarchy levels whose bottom
> layers (aka leaf nodes in device tree syntax) contain links to the HW
> CPUs in the system.
>
> The topology bindings are generic for both 32-bit and 64-bit systems and
> lay the groundwork on top of which affinity schemes can be built.
By affinity schemes, you mean further bindings? Do we need this binding
until that point?
As is, I don't have much comment.
[snip]
> +Example 3 (ARM 32-bit, cortex-a8 single core):
> +
> +cpus {
> + #size-cells = <0>;
> + #address-cells = <1>;
> +
> + cpu-map {
> + cluster0 {
> + core0 {
> + cpu = <&CPU0>;
> + };
> + };
> + };
This example seems utterly pointless. I think we should be specific that
single core does not contain a cpu-map. I suppose we could have a
threaded, single core case, but let's address that if we ever do.
Rob
> +
> + CPU0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a8";
> + reg = <0x0>;
> + };
> +};
> +
> +===============================================================================
> +[1] ARM Linux kernel documentation
> + Documentation/devicetree/bindings/arm/cpus.txt
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-13 21:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 9:42 [PATCH 0/2] ARM DT cpus/cpu and topology bindings Lorenzo Pieralisi
2013-08-15 9:42 ` [PATCH 1/2] Documentation: devicetree: arm: cpus/cpu nodes bindings updates Lorenzo Pieralisi
2013-08-15 14:32 ` Rob Herring
2013-08-15 15:22 ` Lorenzo Pieralisi
2013-08-19 10:34 ` Afzal Mohammed
2013-09-13 16:57 ` Lorenzo Pieralisi
2013-09-13 16:57 ` Lorenzo Pieralisi
2013-09-13 20:51 ` Rob Herring
2013-09-13 20:51 ` Rob Herring
2013-09-14 7:49 ` Andrew Lunn
2013-09-14 7:49 ` Andrew Lunn
2013-09-16 8:55 ` Lorenzo Pieralisi
2013-09-16 8:55 ` Lorenzo Pieralisi
2013-09-15 8:36 ` Andrew Lunn
2013-09-15 8:36 ` Andrew Lunn
2013-09-16 8:57 ` Lorenzo Pieralisi
2013-09-16 8:57 ` Lorenzo Pieralisi
2013-08-16 23:15 ` Stephen Warren
2013-08-28 19:45 ` Grant Likely
2013-08-28 19:45 ` Grant Likely
2013-08-15 9:42 ` [PATCH 2/2] Documentation: DT: arm: define CPU topology bindings Lorenzo Pieralisi
2013-09-13 16:39 ` Lorenzo Pieralisi
2013-09-13 16:39 ` Lorenzo Pieralisi
2013-09-13 21:07 ` Rob Herring [this message]
2013-09-13 21:07 ` Rob Herring
2013-09-16 9:10 ` Lorenzo Pieralisi
2013-09-16 9:10 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52337E7F.9010802@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.