From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 5/5] staging: iio: tsl2x7x_core: Remove redundant break
Date: Sat, 14 Sep 2013 11:37:58 +0100 [thread overview]
Message-ID: <52343C86.8040109@kernel.org> (raw)
In-Reply-To: <1378894829-8173-5-git-send-email-sachin.kamat@linaro.org>
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 3439d37..9c43dcf 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -951,7 +951,6 @@ static ssize_t tsl2x7x_gain_available_show(struct device *dev,
> case tsl2771:
> case tmd2771:
> return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 128");
> - break;
> }
>
> return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 120");
> @@ -1346,7 +1345,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
> break;
> default:
> return -EINVAL;
> - break;
> }
> break;
> case IIO_CHAN_INFO_RAW:
> @@ -1366,7 +1364,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
> break;
> default:
> return -EINVAL;
> - break;
> }
> break;
> case IIO_CHAN_INFO_CALIBSCALE:
> @@ -1419,7 +1416,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
> case tsl2772:
> case tmd2772:
> return -EINVAL;
> - break;
> }
> chip->tsl2x7x_settings.als_gain = 3;
> break;
> @@ -1431,7 +1427,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
> case tsl2771:
> case tmd2771:
> return -EINVAL;
> - break;
> }
> chip->tsl2x7x_settings.als_gain = 3;
> break;
> @@ -1508,18 +1503,15 @@ static int tsl2x7x_device_id(unsigned char *id, int target)
> case tsl2671:
> case tsl2771:
> return ((*id & 0xf0) == TRITON_ID);
> - break;
> case tmd2671:
> case tmd2771:
> return ((*id & 0xf0) == HALIBUT_ID);
> - break;
> case tsl2572:
> case tsl2672:
> case tmd2672:
> case tsl2772:
> case tmd2772:
> return ((*id & 0xf0) == SWORDFISH_ID);
> - break;
> }
>
> return -EINVAL;
>
next prev parent reply other threads:[~2013-09-14 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
2013-09-11 10:20 ` [PATCH 2/5] iio: gyro: adis16260: " Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 3/5] iio: gyro: adxrs450: " Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 4/5] iio: dac: ad5686: " Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 5/5] staging: iio: tsl2x7x_core: " Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron [this message]
2013-09-14 10:37 ` [PATCH 1/5] iio: gyro: adis16130: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52343C86.8040109@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.