From: Gabriel de Perthuis <g2p.code@gmail.com>
To: Karel Zak <kzak@redhat.com>
Cc: Rolf Fokkens <rolf@rolffokkens.nl>, util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] libblkid: Abort after an incorrect checksum
Date: Sat, 14 Sep 2013 17:59:24 +0200 [thread overview]
Message-ID: <523487DC.1070704@gmail.com> (raw)
In-Reply-To: <1378491089-1135-2-git-send-email-g2p.code@gmail.com>
> Log incorrect checksums and stop the superblock probing loop when
> one is encountered.
> This is to avoid exposing backend devices that are supposed
> to be used through a stacked device (like raid or bcache).
Sorry, but some of the changes you made when applying break the patch.
The intent is to stop the probing loop when a bad container is encountered;
the contents shouldn't be scanned.
That means returning an error from the sb-specific prober doesn't work,
and deferring to superblocks_probe was necessary. I'll send a followup patch.
next prev parent reply other threads:[~2013-09-14 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 18:11 [PATCH 0/2] Deal with incorrect checksums Gabriel de Perthuis
2013-09-06 18:11 ` [PATCH 1/2] libblkid: Abort after an incorrect checksum Gabriel de Perthuis
2013-09-14 15:59 ` Gabriel de Perthuis [this message]
2013-09-16 8:24 ` Karel Zak
2013-09-16 10:10 ` Gabriel de Perthuis
2013-09-16 11:11 ` Karel Zak
2013-09-14 17:03 ` [PATCH] " Gabriel de Perthuis
2013-09-06 18:11 ` [PATCH 2/2] wipefs: Also wipe superblocks with bad checksums Gabriel de Perthuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523487DC.1070704@gmail.com \
--to=g2p.code@gmail.com \
--cc=kzak@redhat.com \
--cc=rolf@rolffokkens.nl \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.