From: Randy Dunlap <rdunlap@infradead.org>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: benh@kernel.crashing.org, rob@landley.net, ananth@in.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
masami.hiramatsu.pt@hitachi.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] doc: fix some typos
Date: Sat, 14 Sep 2013 09:49:18 -0700 [thread overview]
Message-ID: <5234938E.7010809@infradead.org> (raw)
In-Reply-To: <5233DCD1.4010006@huawei.com>
On 09/13/13 20:49, Xishi Qiu wrote:
> diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
> index 0cfb00f..ca278d5 100644
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -92,7 +92,7 @@ stack contents as the probed function. When it is done, the handler
> calls jprobe_return(), which traps again to restore the original stack
> contents and processor state and switch to the probed function.
>
> -By convention, the callee owns its arguments, so gcc may produce code
Are you sure about that?
It looks correct to me (before the patch).
> +By convention, the caller owns its arguments, so gcc may produce code
> that unexpectedly modifies that portion of the stack. This is why
> Kprobes saves a copy of the stack and restores it after the jprobe
> handler has run. Up to MAX_STACK_SIZE bytes are copied -- e.g.,
>
--
~Randy
next prev parent reply other threads:[~2013-09-14 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 3:49 [PATCH] doc: fix some typos Xishi Qiu
2013-09-14 16:49 ` Randy Dunlap [this message]
2013-09-16 1:42 ` Xishi Qiu
-- strict thread matches above, loose matches on Subject: below --
2016-09-01 11:02 Juergen Gross
2016-09-02 8:30 ` Wei Liu
2016-09-02 8:57 ` Wei Liu
2020-06-16 21:03 Luc Van Oostenryck
2021-01-02 17:40 Thomas Ackermann via GitGitGadget
2021-01-02 21:53 ` Martin Ågren
2021-01-02 22:26 ` Felipe Contreras
2021-01-02 22:59 ` Martin Ågren
2021-01-02 23:40 ` Felipe Contreras
2021-01-03 14:50 ` Chris Torek
2022-09-28 2:35 [PATCH] doc:fix " dominic_riscx
2022-09-28 9:04 ` Andrew Jones
2022-09-28 15:51 ` Xiang W
2022-10-13 4:01 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5234938E.7010809@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=qiuxishi@huawei.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.