From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VKuiC-0004ag-MT
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:36:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VKui6-0005DK-R8
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:36:52 -0400
Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:42378)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VKui6-0005DE-Ji
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:36:46 -0400
Received: by mail-pa0-f51.google.com with SMTP id lf1so3782915pab.38
	for <qemu-devel@nongnu.org>; Sat, 14 Sep 2013 11:36:45 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5234ACB9.9060405@twiddle.net>
Date: Sat, 14 Sep 2013 11:36:41 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1379057606-25727-1-git-send-email-antonynpavlov@gmail.com>
In-Reply-To: <1379057606-25727-1-git-send-email-antonynpavlov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two
 sizes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Stefan Weil <sw@weilnetz.de>

On 09/13/2013 12:33 AM, Antony Pavlov wrote:
> Changes since v2:
>  * commit messages: drop ALL 'Reviewed-by' tags.
>  Drop Aurelien Jarno's tag because the patchseries
>  was completely reworked, so it need additional review.
> 
> Changes since v1:
> 
>  * include/sizes.h -> include/qemu/sizes.h
>  * fix copyright header;
>  * fix formatting: drop tabs;
>  * use the BIT() macro, so it's easy-to-read the constants column;
>  also the BIT() macro casts constant to UL;
>  * rebase on updated master;
>  * take into account the "mips_malta: support up to 2GiB RAM" commit.
> 
> [RFC v3 1/2] include/qemu: introduce sizes.h
> [RFC v3 2/2] hw/mips: use sizes.h macros
> 
> The sizes.h macros is a easy-to-read method of
> power-of-two memory sizes representation. The sizes.h
> macros are actively used in linux kernel and other
> projects, so let's use them in QEMU too.
> 

Seems reasonable.  I'd have said why bother with some of
the multiples, except for the crossover with the linux kernel.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~