From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL5vy-0008HR-2z
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:35:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL5vs-0005JR-4X
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:35:50 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=54211
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL5vr-0005JM-Te
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:35:44 -0400
Message-ID: <5235553C.5000400@weilnetz.de>
Date: Sun, 15 Sep 2013 08:35:40 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1379203434-5680-1-git-send-email-rth@twiddle.net>
	<1379203434-5680-4-git-send-email-rth@twiddle.net>
In-Reply-To: <1379203434-5680-4-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/8] target-m68k: Rename helpers.h to
	helper.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, aurelien@aurel32.net, Paul Brook <paul@codesourcery.com>

Am 15.09.2013 02:03, schrieb Richard Henderson:
> This brings the m68k target in line with all other targets.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-m68k/helper.c                | 2 +-
>  target-m68k/{helpers.h => helper.h} | 0
>  target-m68k/op_helper.c             | 2 +-
>  target-m68k/translate.c             | 6 +++---
>  4 files changed, 5 insertions(+), 5 deletions(-)
>  rename target-m68k/{helpers.h => helper.h} (100%)
>
> diff --git a/target-m68k/helper.c b/target-m68k/helper.c
> index 00a7a08..a508896 100644
> --- a/target-m68k/helper.c
> +++ b/target-m68k/helper.c
> @@ -21,7 +21,7 @@
>  #include "cpu.h"
>  #include "exec/gdbstub.h"
>  
> -#include "helpers.h"
> +#include "helper.h"
>  
>  #define SIGNBIT (1u << 31)
>  
> diff --git a/target-m68k/helpers.h b/target-m68k/helper.h
> similarity index 100%
> rename from target-m68k/helpers.h
> rename to target-m68k/helper.h
> diff --git a/target-m68k/op_helper.c b/target-m68k/op_helper.c
> index 30f7d8b..bbbfd7f 100644
> --- a/target-m68k/op_helper.c
> +++ b/target-m68k/op_helper.c
> @@ -17,7 +17,7 @@
>   * License along with this library; if not, see <http://www.gnu.org/licenses/>.
>   */
>  #include "cpu.h"
> -#include "helpers.h"
> +#include "helper.h"
>  
>  #if defined(CONFIG_USER_ONLY)
>  
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 0be0a96..f31e48d 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -23,9 +23,9 @@
>  #include "tcg-op.h"
>  #include "qemu/log.h"
>  
> -#include "helpers.h"
> +#include "helper.h"
>  #define GEN_HELPER 1
> -#include "helpers.h"
> +#include "helper.h"
>  
>  //#define DEBUG_DISPATCH 1
>  
> @@ -110,7 +110,7 @@ void m68k_tcg_init(void)
>      store_dummy = tcg_global_mem_new(TCG_AREG0, -8, "NULL");
>  
>  #define GEN_HELPER 2
> -#include "helpers.h"
> +#include "helper.h"
>  }
>  
>  static inline void qemu_assert(int cond, const char *msg)

Reviewed-by: Stefan Weil <sw@weilnetz.de>