From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL6Mm-0004hs-K0
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 03:03:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL6Mg-0003cc-Og
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 03:03:32 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=56935
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VL6Mg-0003cP-IF
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 03:03:26 -0400
Message-ID: <52355BB6.4070904@weilnetz.de>
Date: Sun, 15 Sep 2013 09:03:18 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1379203434-5680-1-git-send-email-rth@twiddle.net>
	<1379203434-5680-6-git-send-email-rth@twiddle.net>
In-Reply-To: <1379203434-5680-6-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/8] tcg: Remove stray semi-colons from
	target-*/helper.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, PowerPC <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, aurelien@aurel32.net

Am 15.09.2013 02:03, schrieb Richard Henderson:
> During GEN_HELPER=3D1, these are actually stray top-level semi-colons
> which are technically invalid ISO C, but GCC accepts as an extension.
> If we added enough __extension__ markers that we could dare use
> -Wpedantic, we'd see
>
>   warning: ISO C does not allow extra =E2=80=98;=E2=80=99 outside of a =
function
>
> This will become a hard error in the next patch, wherein those ; will
> appear in the middle of a data structure.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---

Instead of removing the semicolons from the DEF_HELPER_x lines,
I'd prefer removing them from the DEF_HELPER_FLAGS_x definitions.

Code formatters and static code analyzers (maybe humans, too) prefer
lines which look like valid C syntax, therefore

DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64);

is better for such tools than

DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64)

The compiler will also complain if someone adds a new DEF_HELPER_FLAGS_x
without semicolon in the first case, but it won't complain if someone add=
s
it with semicolon in the second case.

Regards,
Stefan