Re: [PATCH 3/4] drm: omap: Enable DT support for DMM

[Archit Taneja <archit-l0cyMroinI0@public.gmane.org>]

On Friday 13 September 2013 07:44 PM, Rob Clark wrote:
> On Fri, Sep 13, 2013 at 5:14 AM, Archit Taneja <archit-l0cyMroinI0@public.gmane.org> wrote:
>> Enable use of DT for DMM/Tiler.
>>
>> Originally worked on by Andy Gross.
>
> looks good.. but do we want to get information about # of LUT's, etc,
> from DT?  Or did we decide that we can reliably get this from the hw?
> I lost track of that discussion (I guess Andy would remember)..

I am not aware of the discussion either. But looks like we get the LUT 
info from the HW registers in omap_dmm_probe:

         hwinfo = readl(omap_dmm->base + DMM_PAT_HWINFO);
         omap_dmm->num_engines = (hwinfo >> 24) & 0x1F;
         omap_dmm->num_lut = (hwinfo >> 16) & 0x1F;
         omap_dmm->container_width = 256;
         omap_dmm->container_height = 128;

         atomic_set(&omap_dmm->engine_counter, omap_dmm->num_engines);

         /* read out actual LUT width and height */
         pat_geom = readl(omap_dmm->base + DMM_PAT_GEOMETRY);
         omap_dmm->lut_width = ((pat_geom >> 16) & 0xF) << 5;
         omap_dmm->lut_height = ((pat_geom >> 24) & 0xF) << 5;

         /* increment LUT by one if on OMAP5 */
         /* LUT has twice the height, and is split into a separate 
container */
         if (omap_dmm->lut_height != omap_dmm->container_height)
                 omap_dmm->num_lut++;


Archit
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html