From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLTlR-0003Sh-Sf for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:02:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLTlN-0006Kr-Ar for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:02:33 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:47044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLTlN-0006Kd-2S for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:02:29 -0400 Message-ID: <5236BB0B.2020304@huawei.com> Date: Mon, 16 Sep 2013 10:02:19 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1379195690-6509-1-git-send-email-rth@twiddle.net> <1379195690-6509-8-git-send-email-rth@twiddle.net> In-Reply-To: <1379195690-6509-8-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 07/33] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 14.09.2013 23:54, Richard Henderson wrote: > It was unused. Let's not overcomplicate things before we need them. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index be6d05a..cc56fe5 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -543,10 +543,10 @@ static inline void tcg_out_rotl(TCGContext *s, TCGType ext, > } > > static inline void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, > - TCGReg rm, int shift_imm) > + TCGReg rm) > { > /* Using CMP alias SUBS wzr, Wn, Wm */ > - tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, shift_imm); > + tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, 0); > } > > static inline void tcg_out_cset(TCGContext *s, TCGType ext, > @@ -920,7 +920,7 @@ static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, > (is_read ? offsetof(CPUTLBEntry, addr_read) > : offsetof(CPUTLBEntry, addr_write))); > /* Perform the address comparison. */ > - tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3, 0); > + tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3); > *label_ptr = s->code_ptr; > /* If not equal, we jump to the slow path. */ > tcg_out_goto_cond_noaddr(s, TCG_COND_NE); > @@ -1259,13 +1259,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > > case INDEX_op_brcond_i64: > case INDEX_op_brcond_i32: > - tcg_out_cmp(s, ext, a0, a1, 0); > + tcg_out_cmp(s, ext, a0, a1); > tcg_out_goto_label_cond(s, a2, args[3]); > break; > > case INDEX_op_setcond_i64: > case INDEX_op_setcond_i32: > - tcg_out_cmp(s, ext, a1, a2, 0); > + tcg_out_cmp(s, ext, a1, a2); > tcg_out_cset(s, 0, a0, args[3]); > break; > > agreed. This is an artifact from a previous implementation of the tlb lookup. Reviewed-by: Claudio Fontana