From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VLaRV-00024x-CQ
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:10:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VLaRO-0004X3-3k
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:10:25 -0400
Received: from ex-e-2.perimeter.fzi.de ([141.21.8.251]:56596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VLaRN-0004Wi-Sw
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:10:18 -0400
Message-ID: <52371F58.1030303@fzi.de>
Date: Mon, 16 Sep 2013 17:10:16 +0200
From: Sebastian Ottlik <ottlik@fzi.de>
MIME-Version: 1.0
References: <1379341429-29141-1-git-send-email-ottlik@fzi.de>
	<52371BCB.4090004@redhat.com>
In-Reply-To: <52371BCB.4090004@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 16.09.2013 16:55, Paolo Bonzini wrote:
> Il 16/09/2013 16:23, Sebastian Ottlik ha scritto:
>> - Added the silent flag to socket_set_fast_reuse controlling error reporting
>>    One location where SO_REUSEADDR was set would report errors if setting the
>>    option failed. Keeping the reporting code there would be somewhat unclean, so
>>    I moved it to socket_set_fast_reuse. A side effect of this was that the error
>>    reporting was added for all locations that now use socket_set_fast_reuse. Here
>>    a new flag is added to control error reporting, which means this patchset
>>    won't change QEMU behaviour (except for not setting SO_REUSEADDR on Windows).
> Is there actually a case where setting SO_REUSEADDR could fail?
>
> Paolo
Yes, but its very unlikely. E.g. the first parameter is not a valid socket.