From: Larry Finger <Larry.Finger@lwfinger.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/8 V2] rtlwifi: rtl8192_common: Fix smatch errors and warnings in rtl8192c/dm_common.c
Date: Mon, 16 Sep 2013 14:07:07 -0500 [thread overview]
Message-ID: <523756DB.90507@lwfinger.net> (raw)
In-Reply-To: <523755D1.2010003@cogentembedded.com>
On 09/16/2013 02:02 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 09/16/2013 10:55 PM, Larry Finger wrote:
>
>> Smatch lists the following:
>> CHECK drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
>> info: ignoring unreachable code.
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
>> info: ignoring unreachable code.
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:882
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:883
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:891
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:892
>> rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
>> 'txpwr_level' 2 <= 2
>
>> The unreachable code message is fixed by commenting out the code that follows
>> a return.
>
> You've commented out the whole function body, where is the *return* you're
> talking about?
The return is in the middle of the function body just after the variable
declarations. It does not show in the diff listing, but it is there. What should
I do?
Larry
next prev parent reply other threads:[~2013-09-16 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 18:55 [PATCH 0/8i V2] rtlwifi: Patches to fix problems shown by smatch Larry Finger
2013-09-16 18:55 ` [PATCH 1/8 V2] rtlwifi: rtl8192du: Fix smatch errors in /rtl8192de/dm.c Larry Finger
2013-09-16 18:55 ` [PATCH 2/8 V2] rtlwifi: rtl8192de: Fix smatch warnings in rtl8192de/hw.c Larry Finger
2013-09-16 18:55 ` Larry Finger
2013-09-16 21:44 ` Kalle Valo
2013-09-16 21:44 ` Kalle Valo
2013-09-16 18:55 ` [PATCH 3/8 V2] rtlwifi: rtl8192cu: Fix smatch warning in rtl8192cu/trx.c Larry Finger
2013-09-16 19:05 ` Sergei Shtylyov
2013-09-16 19:05 ` Sergei Shtylyov
2013-09-16 18:55 ` [PATCH 4/8 V2] rtlwifi: rtl8192_common: Fix smatch errors and warnings in rtl8192c/dm_common.c Larry Finger
2013-09-16 18:55 ` Larry Finger
2013-09-16 19:02 ` Sergei Shtylyov
2013-09-16 19:02 ` Sergei Shtylyov
2013-09-16 19:07 ` Larry Finger [this message]
2013-09-16 19:10 ` Sergei Shtylyov
2013-09-16 18:55 ` [PATCH 5/8 V2] [PATCH 5/7: rtlwifi: Fix smatch warning in pci.c Larry Finger
2013-09-16 18:55 ` Larry Finger
2013-09-16 19:04 ` Sergei Shtylyov
2013-09-16 19:04 ` Sergei Shtylyov
2013-09-16 19:11 ` Sergei Shtylyov
2013-09-16 18:55 ` [PATCH 6/8 V2] rtlwifi: Fix smatch warnings in usb.c Larry Finger
2013-09-16 18:55 ` Larry Finger
2013-09-16 19:07 ` Sergei Shtylyov
2013-09-16 19:07 ` Sergei Shtylyov
2013-09-16 18:55 ` [PATCH 7/8 V2] rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c Larry Finger
2013-09-16 18:55 ` [PATCH 8/8 V2] rtlwifi: Remove variable 'noise' from rtl_stats struct Larry Finger
2013-09-16 18:55 ` Larry Finger
2013-09-17 8:48 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523756DB.90507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.