From: Stephen Warren <swarren@wwwdotorg.org>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-pwm@vger.kernel.org, Grant Likely <grant.likely@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chao Xie <chao.xie@marvell.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3] PWM: PXA: add device tree support to PWM driver
Date: Mon, 16 Sep 2013 13:44:49 -0600 [thread overview]
Message-ID: <52375FB1.5050700@wwwdotorg.org> (raw)
In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com>
On 09/13/2013 10:54 AM, Mike Dunn wrote:
> This patch adds device tree support to the PXA's PWM driver. Only an OF match
> table is added; nothing needs to be extracted from the device tree node. The
> existing ID table is reused for the match table data.
>
> Tested on a Palm Treo 680 (both platform data and DT cases).
> diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
> +- compatible: should be one of:
> + - "marvell,pxa250-pwm"
> + - "marvell,pxa270-pwm"
> + - "marvell,pxa168-pwm"
> + - "marvell,pxa910-pwm"
Not just one of, but possible more than one...
> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> + pwm0: pwm@40b00000 {
> + compatible = "marvell,pxa270-pwm";
I thought the assertion was that pax270 and pxa250 were both compatible?
If so, that should be:
compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm";
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PWM: PXA: add device tree support to PWM driver
Date: Mon, 16 Sep 2013 13:44:49 -0600 [thread overview]
Message-ID: <52375FB1.5050700@wwwdotorg.org> (raw)
In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com>
On 09/13/2013 10:54 AM, Mike Dunn wrote:
> This patch adds device tree support to the PXA's PWM driver. Only an OF match
> table is added; nothing needs to be extracted from the device tree node. The
> existing ID table is reused for the match table data.
>
> Tested on a Palm Treo 680 (both platform data and DT cases).
> diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
> +- compatible: should be one of:
> + - "marvell,pxa250-pwm"
> + - "marvell,pxa270-pwm"
> + - "marvell,pxa168-pwm"
> + - "marvell,pxa910-pwm"
Not just one of, but possible more than one...
> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> + pwm0: pwm at 40b00000 {
> + compatible = "marvell,pxa270-pwm";
I thought the assertion was that pax270 and pxa250 were both compatible?
If so, that should be:
compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm";
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mike Dunn <mikedunn-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org>
Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chao Xie <chao.xie-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3] PWM: PXA: add device tree support to PWM driver
Date: Mon, 16 Sep 2013 13:44:49 -0600 [thread overview]
Message-ID: <52375FB1.5050700@wwwdotorg.org> (raw)
In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org>
On 09/13/2013 10:54 AM, Mike Dunn wrote:
> This patch adds device tree support to the PXA's PWM driver. Only an OF match
> table is added; nothing needs to be extracted from the device tree node. The
> existing ID table is reused for the match table data.
>
> Tested on a Palm Treo 680 (both platform data and DT cases).
> diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
> +- compatible: should be one of:
> + - "marvell,pxa250-pwm"
> + - "marvell,pxa270-pwm"
> + - "marvell,pxa168-pwm"
> + - "marvell,pxa910-pwm"
Not just one of, but possible more than one...
> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> + pwm0: pwm@40b00000 {
> + compatible = "marvell,pxa270-pwm";
I thought the assertion was that pax270 and pxa250 were both compatible?
If so, that should be:
compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm";
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-16 19:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:54 [PATCH v3] PWM: PXA: add device tree support to PWM driver Mike Dunn
2013-09-13 16:54 ` Mike Dunn
2013-09-13 16:54 ` Mike Dunn
2013-09-15 14:07 ` Marek Vasut
2013-09-15 14:07 ` Marek Vasut
2013-09-15 14:07 ` Marek Vasut
2013-09-16 14:42 ` Mike Dunn
2013-09-16 14:42 ` Mike Dunn
2013-09-16 14:42 ` Mike Dunn
2013-09-16 15:10 ` Marek Vasut
2013-09-16 15:10 ` Marek Vasut
2013-09-16 15:10 ` Marek Vasut
2013-09-16 19:45 ` Stephen Warren
2013-09-16 19:45 ` Stephen Warren
2013-09-16 19:45 ` Stephen Warren
2013-09-16 23:00 ` Marek Vasut
2013-09-16 23:00 ` Marek Vasut
2013-09-16 23:00 ` Marek Vasut
2013-09-16 19:44 ` Stephen Warren [this message]
2013-09-16 19:44 ` Stephen Warren
2013-09-16 19:44 ` Stephen Warren
2013-09-16 23:01 ` Marek Vasut
2013-09-16 23:01 ` Marek Vasut
2013-09-16 23:01 ` Marek Vasut
2013-09-16 23:03 ` Stephen Warren
2013-09-16 23:03 ` Stephen Warren
2013-09-16 23:03 ` Stephen Warren
2013-09-17 14:07 ` Mike Dunn
2013-09-17 14:07 ` Mike Dunn
2013-09-17 14:07 ` Mike Dunn
2013-09-17 16:17 ` Stephen Warren
2013-09-17 16:17 ` Stephen Warren
2013-09-17 16:17 ` Stephen Warren
2013-09-17 18:56 ` Mike Dunn
2013-09-17 18:56 ` Mike Dunn
2013-09-17 18:56 ` Mike Dunn
2013-09-17 19:26 ` Stephen Warren
2013-09-17 19:26 ` Stephen Warren
2013-09-17 19:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52375FB1.5050700@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=chao.xie@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=mikedunn@newsguy.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robert.jarzmik@free.fr \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.