From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <52375FB1.5050700@wwwdotorg.org> Date: Mon, 16 Sep 2013 13:44:49 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH v3] PWM: PXA: add device tree support to PWM driver References: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com> In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: To: Mike Dunn Cc: linux-pwm@vger.kernel.org, Grant Likely , Thierry Reding , Rob Herring , Haojian Zhuang , Robert Jarzmik , Marek Vasut , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dmitry Torokhov , Chao Xie , Sergei Shtylyov , Pawel Moll , Mark Rutland , Ian Campbell On 09/13/2013 10:54 AM, Mike Dunn wrote: > This patch adds device tree support to the PXA's PWM driver. Only an OF match > table is added; nothing needs to be extracted from the device tree node. The > existing ID table is reused for the match table data. > > Tested on a Palm Treo 680 (both platform data and DT cases). > diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt > +- compatible: should be one of: > + - "marvell,pxa250-pwm" > + - "marvell,pxa270-pwm" > + - "marvell,pxa168-pwm" > + - "marvell,pxa910-pwm" Not just one of, but possible more than one... > diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > + pwm0: pwm@40b00000 { > + compatible = "marvell,pxa270-pwm"; I thought the assertion was that pax270 and pxa250 were both compatible? If so, that should be: compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 16 Sep 2013 13:44:49 -0600 Subject: [PATCH v3] PWM: PXA: add device tree support to PWM driver In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com> References: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com> Message-ID: <52375FB1.5050700@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/13/2013 10:54 AM, Mike Dunn wrote: > This patch adds device tree support to the PXA's PWM driver. Only an OF match > table is added; nothing needs to be extracted from the device tree node. The > existing ID table is reused for the match table data. > > Tested on a Palm Treo 680 (both platform data and DT cases). > diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt > +- compatible: should be one of: > + - "marvell,pxa250-pwm" > + - "marvell,pxa270-pwm" > + - "marvell,pxa168-pwm" > + - "marvell,pxa910-pwm" Not just one of, but possible more than one... > diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > + pwm0: pwm at 40b00000 { > + compatible = "marvell,pxa270-pwm"; I thought the assertion was that pax270 and pxa250 were both compatible? If so, that should be: compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3] PWM: PXA: add device tree support to PWM driver Date: Mon, 16 Sep 2013 13:44:49 -0600 Message-ID: <52375FB1.5050700@wwwdotorg.org> References: <1379091281-23662-1-git-send-email-mikedunn@newsguy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379091281-23662-1-git-send-email-mikedunn-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Dunn Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely , Thierry Reding , Rob Herring , Haojian Zhuang , Robert Jarzmik , Marek Vasut , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dmitry Torokhov , Chao Xie , Sergei Shtylyov , Pawel Moll , Mark Rutland , Ian Campbell List-Id: devicetree@vger.kernel.org On 09/13/2013 10:54 AM, Mike Dunn wrote: > This patch adds device tree support to the PXA's PWM driver. Only an OF match > table is added; nothing needs to be extracted from the device tree node. The > existing ID table is reused for the match table data. > > Tested on a Palm Treo 680 (both platform data and DT cases). > diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt > +- compatible: should be one of: > + - "marvell,pxa250-pwm" > + - "marvell,pxa270-pwm" > + - "marvell,pxa168-pwm" > + - "marvell,pxa910-pwm" Not just one of, but possible more than one... > diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > + pwm0: pwm@40b00000 { > + compatible = "marvell,pxa270-pwm"; I thought the assertion was that pax270 and pxa250 were both compatible? If so, that should be: compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html