From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:max1361: Use default triggered buffer setup ops
Date: Mon, 16 Sep 2013 22:38:42 +0100 [thread overview]
Message-ID: <52377A62.8040600@kernel.org> (raw)
In-Reply-To: <1379320489-27334-1-git-send-email-lars@metafoo.de>
On 09/16/13 09:34, Lars-Peter Clausen wrote:
> The max1361 driver uses the same callbacks as the triggered buffer default
> buffer setup ops, so just remove the max1361 specific ops and let it use the
> default ops.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks. Applied to the togreg branch of ii
> ---
> drivers/iio/adc/max1363.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 4fb35d1..1e7160d 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -1484,12 +1484,6 @@ done:
> return IRQ_HANDLED;
> }
>
> -static const struct iio_buffer_setup_ops max1363_buffered_setup_ops = {
> - .postenable = &iio_triggered_buffer_postenable,
> - .preenable = &iio_sw_buffer_preenable,
> - .predisable = &iio_triggered_buffer_predisable,
> -};
> -
> static int max1363_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> @@ -1559,7 +1553,7 @@ static int max1363_probe(struct i2c_client *client,
> goto error_disable_reg;
>
> ret = iio_triggered_buffer_setup(indio_dev, NULL,
> - &max1363_trigger_handler, &max1363_buffered_setup_ops);
> + &max1363_trigger_handler, NULL);
> if (ret)
> goto error_disable_reg;
>
>
prev parent reply other threads:[~2013-09-16 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 8:34 [PATCH] iio:max1361: Use default triggered buffer setup ops Lars-Peter Clausen
2013-09-16 21:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52377A62.8040600@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.