From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] xfstests: add d_type checking to fsstress
Date: Mon, 16 Sep 2013 17:22:12 -0500 [thread overview]
Message-ID: <52378494.7000406@sgi.com> (raw)
In-Reply-To: <52377E50.3040907@redhat.com>
On 09/16/13 16:55, Eric Sandeen wrote:
> This patch adds a "-D" switch to fsstress so that every time
> we call readdir, we stat the dentry& compare it's st_mode
> to the d_type.
>
> If -D is specified only once, it ignores DT_UNKNOWN. If specified
> twice, it considers DT_UNKNOWN to be an error.
>
> It skips paths of "./." and "./.." so that we only look at files
> newly created within the filesystem.
>
> This could be used in an xfstest; it's noisy on a failures so
> would break expected output.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> fsstress doesn't usually do validation, but it's such a handy
> framework for creating a ton of random files, this seems like
> an ok place to put it. What do folks think?
I tried v5 and v4 with and without inode fields in the directory.
This looks good to me. Like the 2 levels of the test.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-16 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 21:55 [PATCH, RFC] xfstests: add d_type checking to fsstress Eric Sandeen
2013-09-16 22:22 ` Mark Tinguely [this message]
2013-09-16 22:55 ` Dave Chinner
2013-09-16 23:20 ` Eric Sandeen
2013-09-17 0:54 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52378494.7000406@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.